Hi Micah, Thanks a lot for your feedback.
In the PR, I have updated the java/dev/checkstyle/checkstyle.xml file to enforce checking this problem. So it will check the code for this problem as part of the CI. Best, Liya Fan On Tue, Dec 24, 2019 at 3:43 PM Micah Kornfield <emkornfi...@gmail.com> wrote: > Hi Liya Fan, > Thank you for the PR and starting the discussion. Sorry if I missed it but > is there something the PR to prevent these problems from reappearing? > > My personal preference would be to find a mechanism to enforce code style. > Run it once (and accept it might be a large change) and from that point > forward validate the format as part of CI. > > Cheers, > Micah > > On Wed, Dec 18, 2019 at 1:44 AM Fan Liya <liya.fa...@gmail.com> wrote: > > > Dear all, > > > > We want to enhance the Java code style checking. > > > > This is due to a discussion in [1]. In the discussion, we found the > current > > style checking for Java code is not sufficient. So we want to enhace it > in > > a series of "small" steps, in order to avoid having to change too many > > files at once. > > > > Currently, we have opened a JIRA [2] to track the problem of consecutive > > spaces between tokens. An initial PR [3] is prepared. Please see if it > > looks good to you. > > > > > > Thank you in advance. > > > > Best regards, > > > > Liya Fan > > > > > > [1] https://github.com/apache/arrow/pull/5861#discussion_r348917065 > > [2] https://issues.apache.org/jira/browse/ARROW-7429 > > [3] https://github.com/apache/arrow/pull/6060 > > >
