I re-verified the macOS wheels and they worked but I had to hard-code `MACOSX_DEPLOYMENT_TARGET="10.14"` to get past the cython error I reported previously. I tried to set that env var dynamically based on your current OS version but didn't succeed in getting it passed through to pytest, despite many attempts to `export` it; someone with better bash skills than I should probably add that to the script. FTR `defaults read loginwindow SystemVersionStampAsString | sed s/\.[0-9]$//` returns the right macOS version.
Neal On Wed, Feb 5, 2020 at 1:29 PM Wes McKinney <wesmck...@gmail.com> wrote: > +1 (binding) > > I was able to verify the Windows wheels with the following patch applied > > https://github.com/apache/arrow/pull/6364 > > On Wed, Feb 5, 2020 at 1:09 PM Krisztián Szűcs > <szucs.kriszt...@gmail.com> wrote: > > > > There were binary naming issues with the macosx and the win-cp38 > > wheels. > > I've uploaded them, all of the wheels should be available now [1] > > > > Note that the newly built macosx wheels have 10_9 platform tag > > instead of 10_6, so the verification script must be updated [2] to > > verify the macosx wheels. > > > > [1] https://bintray.com/apache/arrow/python-rc/0.16.0-rc2#files > > [2] > https://github.com/apache/arrow/pull/6362/files#diff-8cc7fa3ae5de30b356c17d7a4b59fe09R658 > > > > On Wed, Feb 5, 2020 at 6:30 PM Krisztián Szűcs > > <szucs.kriszt...@gmail.com> wrote: > > > > > > The wheel was built successfully and available under the crossbow > > > releases. Something must have gone wrong during download/upload > > > to bintray. I'm re-uploading the wheels again, waiting for the network. > > > > > > On Wed, Feb 5, 2020 at 6:14 PM Wes McKinney <wesmck...@gmail.com> > wrote: > > > > > > > > The Windows wheel RC script is broken > > > > > > > > wget --no-check-certificate -O > pyarrow-0.16.0-cp38-cp38m-win_amd64.whl > > > > > https://bintray.com/apache/arrow/download_file?file_path=python-rc%2F0.16.0-rc2%2Fpyarrow-0.1 > > > > 6.0-cp38-cp38m-win_amd64.whl || EXIT /B 1 > > > > --2020-02-05 11:11:15-- > > > > > https://bintray.com/apache/arrow/download_file?file_path=python-rc%2F0.16.0-rc2%2Fpyarrow-0.16.0-cp38-cp38m-win_amd64.whl > > > > Resolving bintray.com (bintray.com)... 75.126.208.206 > > > > Connecting to bintray.com (bintray.com)|75.126.208.206|:443... > > > > connected. > > > > HTTP request sent, awaiting response... 404 Not Found > > > > 2020-02-05 11:11:15 ERROR 404: Not Found. > > > > > > > > I will try to fix > > > > > > > > On Wed, Feb 5, 2020 at 7:31 AM Uwe L. Korn <uw...@xhochy.com> wrote: > > > > > > > > > > I'm failing to verify C++ on macOS as it seems that we nowadays > pull all dependencies from the system. Is there a known way to build & test > on OSX with the script and use conda for the requirements? > > > > > > > > > > Otherwise I probably need to investe to create such a way. > > > > > > > > > > Cheers > > > > > Uwe > > > > > > > > > > On Wed, Feb 5, 2020, at 2:54 AM, Krisztián Szűcs wrote: > > > > > > Hi, > > > > > > > > > > > > I've cherry-picked the wheel fix [1] on top of the 0.16 release > tag, > > > > > > re-built the wheels using crossbow [2], and uploaded them to > > > > > > bintray [3] (also removed win-py38m). > > > > > > > > > > > > Anyone who has voted after verifying the wheels, please re-run > > > > > > the verification script again for the wheels and re-vote. > > > > > > > > > > > > Thanks, Krisztian > > > > > > > > > > > > [1] > > > > > > > https://github.com/apache/arrow/commit/67e34c53b3be4c88348369f8109626b4a8a997aa > > > > > > [2] > https://github.com/ursa-labs/crossbow/branches/all?query=build-733 > > > > > > [3] https://bintray.com/apache/arrow/python-rc/0.16.0-rc2#files > > > > > > > > > > > > On Tue, Feb 4, 2020 at 7:08 PM Wes McKinney <wesmck...@gmail.com> > wrote: > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > Some patches were required to the verification scripts but I > have run: > > > > > > > > > > > > > > * Full source verification on Ubuntu 18.04 > > > > > > > * Linux binary verification > > > > > > > * Source verification on Windows 10 (needed ARROW-6757) > > > > > > > * Windows binary verification. Note that Python 3.8 wheel is > broken > > > > > > > (see ARROW-7755). Whoever uploads the wheels to PyPI _SHOULD > NOT_ > > > > > > > upload this 3.8 wheel until we know what's wrong (if we upload > a > > > > > > > broken wheel then `pip install pyarrow==0.16.0` will be > permanently > > > > > > > broken on Windows/Python 3.8) > > > > > > > > > > > > > > On Mon, Feb 3, 2020 at 9:26 PM Francois Saint-Jacques > > > > > > > <fsaintjacq...@gmail.com> wrote: > > > > > > > > > > > > > > > > Tested on ubuntu 18.04 for the source release. > > > > > > > > > > > > > > > > On Mon, Feb 3, 2020 at 10:07 PM Francois Saint-Jacques > > > > > > > > <fsaintjacq...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > Binaries verification didn't have any issues. > > > > > > > > > Sources verification worked with some local environment > hiccups > > > > > > > > > > > > > > > > > > François > > > > > > > > > > > > > > > > > > On Mon, Feb 3, 2020 at 8:46 PM Andy Grove < > andygrov...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > +1 (binding) based on running the Rust tests > > > > > > > > > > > > > > > > > > > > Thanks. > > > > > > > > > > > > > > > > > > > > On Thu, Jan 30, 2020 at 8:13 PM Krisztián Szűcs < > szucs.kriszt...@gmail.com> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > I would like to propose the following release > candidate (RC2) of Apache > > > > > > > > > > > Arrow version 0.16.0. This is a release consisting of > 728 > > > > > > > > > > > resolved JIRA issues[1]. > > > > > > > > > > > > > > > > > > > > > > This release candidate is based on commit: > > > > > > > > > > > 729a7689fd87572e6a14ad36f19cd579a8b8d9c5 [2] > > > > > > > > > > > > > > > > > > > > > > The source release rc2 is hosted at [3]. > > > > > > > > > > > The binary artifacts are hosted at [4][5][6][7]. > > > > > > > > > > > The changelog is located at [8]. > > > > > > > > > > > > > > > > > > > > > > Please download, verify checksums and signatures, run > the unit tests, > > > > > > > > > > > and vote on the release. See [9] for how to validate a > release candidate. > > > > > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > > > > > > > > > > > > > [ ] +1 Release this as Apache Arrow 0.16.0 > > > > > > > > > > > [ ] +0 > > > > > > > > > > > [ ] -1 Do not release this as Apache Arrow 0.16.0 > because... > > > > > > > > > > > > > > > > > > > > > > [1]: > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%200.16.0 > > > > > > > > > > > [2]: > > > > > > > > > > > > https://github.com/apache/arrow/tree/729a7689fd87572e6a14ad36f19cd579a8b8d9c5 > > > > > > > > > > > [3]: > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-0.16.0-rc2 > > > > > > > > > > > [4]: > https://bintray.com/apache/arrow/centos-rc/0.16.0-rc2 > > > > > > > > > > > [5]: > https://bintray.com/apache/arrow/debian-rc/0.16.0-rc2 > > > > > > > > > > > [6]: > https://bintray.com/apache/arrow/python-rc/0.16.0-rc2 > > > > > > > > > > > [7]: > https://bintray.com/apache/arrow/ubuntu-rc/0.16.0-rc2 > > > > > > > > > > > [8]: > > > > > > > > > > > > https://github.com/apache/arrow/blob/729a7689fd87572e6a14ad36f19cd579a8b8d9c5/CHANGELOG.md > > > > > > > > > > > [9]: > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > > > > > > > > > > > > > > > > >
