It probably pays to have at least two issues one for porting the diff, and the existing one I made.
On Wed, Mar 11, 2020 at 1:45 AM Ji Liu <niki...@aliyun.com> wrote: > Hi Micah, > Thanks for your feedback, you have opened an issue for Google's Truth[1] > and it was assigned to me, I'll try to use it. > > Thanks, > Ji Liu > > [1] https://issues.apache.org/jira/browse/ARROW-6931 > > ------------------------------------------------------------------ > From:Micah Kornfield <emkornfi...@gmail.com> > Send Time:2020年3月11日(星期三) 13:43 > To:dev <dev@arrow.apache.org>; Ji Liu <niki...@aliyun.com> > Subject:Re: [Discuss] [Java] Implement vector diff functionality > > I'm in favor of this. I think this can be combined with a custom matcher > for Google's Truth [1] library, to make a lot of our unit tests much more > readable > > [1] https://github.com/google/truth > > On Thu, Mar 5, 2020 at 11:29 PM Ji Liu <niki...@aliyun.com.invalid> wrote: > > Hi all, > In C++ side, we already have array diff functionality[1] for array equals > and testing to make it easy to see difference between arrays and reduce > debugging time. > I think it’s better to have similar functionality in Java side for better > testing facilities, and I created an issue to track this[2]. > > > Thanks, > Ji Liu > > [1] > https://github.com/apache/arrow/blob/6600a39ffe149971afd5ad3c78c2b538cdc03cfd/cpp/src/arrow/array/diff.h > [2] https://issues.apache.org/jira/browse/ARROW-8019 > >
