+1 for using black On Fri, Mar 27, 2020 at 11:53 AM Joris Van den Bossche < jorisvandenboss...@gmail.com> wrote:
> On Fri, 27 Mar 2020 at 18:49, Antoine Pitrou <solip...@pitrou.net> wrote: > > > > > I don't want to be the small minority opposing this so let's go for it. > > One question though: will we continue to check Cython files using > > flake8? > > > > Yes, and I think we can continue to check flake8 for python files as well. > At > least that is what we do in eg pandas. There are a few things that flake8 > checks that Black doesn't fix automatically. For example comments that are > too long are not reformatted by black, so it's good to keep flake8 working > for that. > > Joris > > > > > > Regards > > > > Antoine. > > > > > > On Thu, 26 Mar 2020 20:37:01 +0100 > > Joris Van den Bossche <jorisvandenboss...@gmail.com> wrote: > > > Hi all, > > > > > > I would like to propose adopting Black as code formatter within the > > python > > > project. There is an older JIRA issue about this ( > > > https://issues.apache.org/jira/browse/ARROW-5176), but bringing it to > > the > > > mailing list for wider attention. > > > > > > Black (https://github.com/ambv/black) is a tool for automatically > > > formatting python code in ways which flake8 and our other linters > approve > > > of (and fill a similar role to clang-format for C++ and cmake-format > for > > > cmake). It can also be added to the linting checks on CI and to the > > > pre-commit hooks like we now run flake8. > > > Using it ensures python code will be formatted consistently, and more > > > importantly automates this formatting, letting you focus on more > > important > > > matters. > > > > > > Black makes some specific formatting choices, and not everybody (me > > > included) will always like those choices (that's how it goes with > > something > > > subjective like formatting). But my experience with using it in some > > other > > > big python projects (pandas, dask) has been very positive. You very > > quickly > > > get used to how it looks, while it is much nicer to not have to worry > > about > > > formatting anymore. > > > > > > Best, > > > Joris > > > > > > > > > > > >
