The vote carries with 4 binding +1 votes and 0 non-binding +1. I will merge the change and open some JIRAs about reading/writing the new field from reference implementations (hopefully tomorrow).
Thanks, Micah On Tue, Jun 30, 2020 at 11:21 PM Micah Kornfield <emkornfi...@gmail.com> wrote: > +1 (binding) > > On Sun, Jun 28, 2020 at 4:39 PM Sutou Kouhei <k...@clear-code.com> wrote: > >> +1 (binding) >> >> In <cak7z5t8c6pcsojdtvoga9vf868h-abdx-oqvw47as44mb-u...@mail.gmail.com> >> "[VOTE] Add a "Feature" enum to Schema.fbs" on Sat, 27 Jun 2020 >> 20:46:55 -0700, >> Micah Kornfield <emkornfi...@gmail.com> wrote: >> >> > Hi, >> > >> > As discussed on the mailing list [1] I would like to add a feature enum >> to >> > enhance our ability to evolve Arrow in a forward compatible manner and >> > allow clients and servers to negotiate which features are supported >> before >> > finalizing the features used. >> > >> > The PR adds a new enum and a field on schema.fbs [2]. We may make >> > modifications to the language in comments but this vote is whether to >> > accept the addition of this enum and field. Details for how this will >> be >> > used in flight, are not part of this change. >> > >> > For clarity, this change is non-breaking and fully backwards >> > compatible. The field ensures that current libraries will be able to >> > determine if a future library version used features that it doesn't >> support >> > (by checking for out of range enum values). It will require libraries >> to >> > both populate the field on writing and check values when reading. >> > >> > The vote will be open for at least 72 hours. >> > >> > [ ] +1 Accept addition of Feature enum flatbuffers field >> > [ ] +0 >> > [ ] -1 Do not accept addition because... >> > >> > [1]: >> > >> https://mail-archives.apache.org/mod_mbox/arrow-dev/202006.mbox/%3CCAK7Z5T-mUB1ipO7YGqwW%3DtcW7eA8_aYvrjWAzLmHw7ZtS09naQ%40mail.gmail.com%3E >> > [2]: https://github.com/apache/arrow/pull/7502 >> >
