Yes, that's ok with me.
Regards Antoine. Le 18/07/2020 à 18:30, Micah Kornfield a écrit : > Antoine are you OK with leaving as is? > > On Fri, Jul 17, 2020 at 3:06 PM Wes McKinney <wesmck...@gmail.com> wrote: > >> My position is that: >> >> * Features only needs to be set with the Schema message, it wouldn't >> be necessary or useful to set it for other message types >> * The metadata version may serve a purpose beyond indicating features >> (and it has in the past already) >> * Thus, it isn't necessarily inconsistent to have these fields at >> different "levels" of the hierarchy, and having "features" be null in >> non-Schema message types might be a different (better or worse?) >> inconsistency >> >> So I would be -0 on changing anything, but maybe there are other >> concerns that I haven't listed >> >> On Fri, Jul 17, 2020 at 4:47 PM Micah Kornfield <emkornfi...@gmail.com> >> wrote: >>> >>> I think this was overlooked. Schema made more sense to me because I was >>> intending it to be at most once per stream. If we can come to agreement >> I >>> can open a PR to change it. But we would need a new release candidate >>> (this can't wait until next release) >>> >>> On Friday, July 17, 2020, Antoine Pitrou <anto...@python.org> wrote: >>> >>>> >>>> Hello, >>>> >>>> A bit too late, I noticed the new "features" field is defined on the >>>> Schema table, while the "version" field is defined on the Message >> table. >>>> Since both fields have closely related purposes (notify the reader of >>>> the conventions used in the stream), I'm a bit surprised that they're >>>> present at different places. Is there a reason I missed for this >>>> seeming inconsistency? >>>> >>>> Regards >>>> >>>> Antoine. >>>> >> >
