Are we concerned about backward compatibility with older FlightClients? Would it make sense to continue to support handshakes with auth payloads in addition to header-based authentication using middlewares? Perhaps we create a dedicated endpoint for server capabilities if we need to remain backward compatible.
On Thu, Sep 3, 2020 at 6:38 AM David Li <li.david...@gmail.com> wrote: > The C++/Python authentication implementation is entirely different > (because the C++/Python/Java gRPC APIs are in turn entirely > different). In particular, gRPC middleware in C++ is still > experimental (compared to Java) and much more limited (unless recent > versions changed this). C++/Python might function better as a set of > middleware implementations in the client which can attach/read headers > as necessary. > > David > > On 9/2/20, James Duong <jam...@bitquilltech.com> wrote: > > Looking towards the future a bit, I don't see some of the facilities we > > used for the Java code in the C++ Flight port. > > Primarily the use of CallOptions -- I don't see existing functionality > for > > wrapping the gRPC stub within the context of > > a single request. I do see that we pass in FlightCallOptions with each > RPC > > call on the client, but the FlightCallOptions > > class doesn't appear to be extensible, and neither do the IpcReadOptions > > and IpcWriteOptions within > > the FlightCallOptions. > > > > On Tue, Sep 1, 2020 at 6:15 PM David Li <li.david...@gmail.com> wrote: > > > >> Hey James, > >> > >> I won't be able to attend tomorrow, but seeing as I've been commenting > >> so far - the changes as summarized in the presentation (+I think the > >> latest comments in the doc) look good to me, thanks for working > >> through the proposal with us. > >> > >> Best, > >> David > >> > >> On 9/1/20, James Duong <jam...@bitquilltech.com> wrote: > >> > Hi, > >> > > >> > I would like to talk about the changes in the design document and PR > in > >> > tomorrow's meeting. > >> > > >> > I've created a slide deck to get the discussion going. > >> > > >> > > >> > https://docs.google.com/presentation/d/1Bcvu0o0SEL21EMazA6O9fVfYZnzyvsQoKKBCN0NIdi0/edit?usp=drivesdk > >> > > >> > Thanks! > >> > > >> > On Wed, Aug 26, 2020, 13:12 James Duong <jam...@bitquilltech.com> > >> > wrote: > >> > > >> >> Hi everyone, > >> >> I've updated the PR and responded to comments in the proposal > >> >> document. > >> >> > >> >> The PR now makes handshake optional and sends auth information with > >> every > >> >> request. > >> >> The client now needs to supply a CredentialCallOption containing auth > >> >> information (as a Consumer<headers>), which > >> >> we'll convert to a gRPC CallCredentials under the hood, and use that > >> >> to > >> >> write headers. > >> >> > >> >> On Thu, Aug 20, 2020 at 2:14 PM James Duong <jam...@bitquilltech.com > > > >> >> wrote: > >> >> > >> >>> Comments should be enabled now. > >> >>> > >> >>> Thanks for the feedback so far. > >> >>> > >> >> > >> >> > >> >> -- > >> >> > >> >> *James Duong* > >> >> Lead Software Developer > >> >> Bit Quill Technologies Inc. > >> >> Direct: +1.604.562.6082 | jam...@bitquilltech.com > >> >> https://www.bitquilltech.com > >> >> > >> >> This email message is for the sole use of the intended recipient(s) > >> >> and > >> >> may contain confidential and privileged information. Any > unauthorized > >> >> review, use, disclosure, or distribution is prohibited. If you are > >> >> not > >> >> the > >> >> intended recipient, please contact the sender by reply email and > >> >> destroy > >> >> all copies of the original message. Thank you. > >> >> > >> > > >> > > > > > > -- > > > > *James Duong* > > Lead Software Developer > > Bit Quill Technologies Inc. > > Direct: +1.604.562.6082 | jam...@bitquilltech.com > > https://www.bitquilltech.com > > > > This email message is for the sole use of the intended recipient(s) and > may > > contain confidential and privileged information. Any unauthorized > review, > > use, disclosure, or distribution is prohibited. If you are not the > > intended recipient, please contact the sender by reply email and destroy > > all copies of the original message. Thank you. > > > -- *James Duong* Lead Software Developer Bit Quill Technologies Inc. Direct: +1.604.562.6082 | jam...@bitquilltech.com https://www.bitquilltech.com This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure, or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. Thank you.
