NumPy's deprecation policy would drop support for the 1.16 series in January: https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table This when I would suggest to up the minimal numpy in builds here to 1.17 and we will also up the version used for builds in conda-forge.
Still, the PR is so trival that we should merge it. I'm not uptodate what the status of the 2.0.1 release is but this would be an essential patch for that. On Fri, Dec 4, 2020, at 9:22 PM, Antoine Pitrou wrote: > > > Le 04/12/2020 à 21:11, Uwe L. Korn a écrit : > > Hello all, > > > > Today the Karotothek CI turned quite red in > > https://github.com/JDASoftwareGroup/kartothek/pull/383 / > > https://github.com/JDASoftwareGroup/kartothek/pull/383/checks?check_run_id=1497941813 > > as the new NumPy 1.20rc1 was pulled in. It simply broke all > > pyarrow<->NumPy interop as now dtypes returned by numpy are actual > > subclasses not directly numpy.dtype instances anymore. I reported the issue > > over at https://github.com/numpy/numpy/issues/17913. We are running into > > that as we build our wheels and conda packages with an older release of > > NumPy that has a faulty implementation of PyArray_DescrCheck. > > > > (a) For upcoming releases, we can either move our minimal supported NumPy > > to 1.16.6 or merge the PR over at https://github.com/apache/arrow/pull/8834 > > I would be fine with merging the PR (assuming comments are added to > explain why things are done that way). Apparently Numpy 1.16.6 is only > one year old. > > Regards > > Antoine. >
