+1 (non-binding) Verified c++ and python on Windows
On Mon, Jan 25, 2021 at 11:47 AM Krisztián Szűcs <szucs.kriszt...@gmail.com> wrote: > On Fri, Jan 22, 2021 at 2:46 PM Neville Dipale <nevilled...@gmail.com> > wrote: > > > > Hi Krisztian, > > > > The full output is at > > https://gist.github.com/nevi-me/88a6279dd90aea30aa4caaa15fb0cc53 > There are failures which seem valid, but didn't occur in the > automatized verification build. > > > > I also ran dev/release/verify-release-candidate-wheels.bat 3.0.0 2 > > > > Getting the below error, it seems to be a Python 3.7 bug, but I'm not yet > > finding a solution for it online. > > > > (C:\tmp\arrow-verify-release-wheels\_verify-wheel-3.6) > > C:\tmp\arrow-verify-release-wheels>pip install > > pyarrow-3.0.0-cp36-cp36m-win_amd64.whl || EXIT /B 1 > > Failed to import the site module > > Traceback (most recent call last): > > File "C:\Users\nevi\anaconda3\lib\site.py", line 579, in <module> > > main() > > File "C:\Users\nevi\anaconda3\lib\site.py", line 566, in main > > known_paths = addsitepackages(known_paths) > > File "C:\Users\nevi\anaconda3\lib\site.py", line 349, in > addsitepackages > > addsitedir(sitedir, known_paths) > > File "C:\Users\nevi\anaconda3\lib\site.py", line 207, in addsitedir > > addpackage(sitedir, name, known_paths) > > File "C:\Users\nevi\anaconda3\lib\site.py", line 159, in addpackage > > f = open(fullname, "r") > > File "C:\Users\nevi\anaconda3\lib\_bootlocale.py", line 12, in > > getpreferredencoding > > if sys.flags.utf8_mode: > > AttributeError: 'sys.flags' object has no attribute 'utf8_mode' > This failure seems to be related to the python installation, the > wheels are supposed to work in the official windows python containers > according to the automatized tests [1]. > > Thanks Neville for running the verification on windows! Sadly we don't > have other verifications from windows, so I need to assume that those > failures are environment/compiler specific. > > [1]: https://github.com/ursacomputing/crossbow/runs/1725090895 > > > > (C:\tmp\arrow-verify-release-wheels\_verify-wheel-3.6) > > C:\tmp\arrow-verify-release-wheels>if errorlevel 1 GOTO error > > > > (C:\tmp\arrow-verify-release-wheels\_verify-wheel-3.6) > > C:\tmp\arrow-verify-release-wheels>call deactivate > > DeprecationWarning: 'deactivate' is deprecated. Use 'conda deactivate'. > > > > (C:\tmp\arrow-verify-release-wheels\_verify-wheel-3.6) > > C:\tmp\arrow-verify-release-wheels>conda.bat deactivate > > > > C:\tmp\arrow-verify-release-wheels>cd C:\Users\nevi\Work\oss\arrow > > > > C:\Users\nevi\Work\oss\arrow>EXIT /B 1 > > > > On Fri, 22 Jan 2021 at 15:14, Krisztián Szűcs <szucs.kriszt...@gmail.com > > > > wrote: > > > > > Thanks Neville for testing it! > > > > > > There should be more context about the failures above the summary. > > > Could you please post the errors? > > > > > > > > > On Fri, Jan 22, 2021 at 2:05 PM Neville Dipale <nevilled...@gmail.com> > > > wrote: > > > > > > > > (+0 non-binding) > > > > > > > > Getting test failures (see end of my mail). > > > > > > > > This is my first time verifying (Windows 10; Insider Preview if > > > relevant), > > > > so I'm > > > > likely missing something in my config. I'll read the verification > script > > > > and try again. > > > > > > > > I ran the below using PowerShell: > > > > > > > > $env:ARROW_GANDIVA=0; $env:ARROW_PLASMA=0; $env:TEST_DEFAULT=0; > > > > $env:TEST_SOURCE=1; $env:TEST_CPP=1; $env:TEST_PYTHON=1; > > > > $env:TEST_JAVA=1; $env:TEST_INTEGRATION_CPP=1; > > > > $env:TEST_INTEGRATION_JAVA=1; > > > > ./dev/release/verify-release-candidate.bat 3.0.0 2 > > > > > > > > I had to change cmake generator to use the below (in line 53): > > > > > > > > set GENERATOR=Visual Studio 16 2019 > > > > > > > > VS 2017 wasn't working for me, even after installing its build tools. > > > > > > > > ____ > > > > > > > > I have 3 test failures per below: > > > > > > > > 94% tests passed, 3 tests failed out of 52 > > > > > > > > Label Time Summary: > > > > arrow-tests = 66.55 sec*proc (30 tests) > > > > arrow_compute = 3.38 sec*proc (4 tests) > > > > arrow_dataset = 0.89 sec*proc (9 tests) > > > > arrow_flight = 0.92 sec*proc (1 test) > > > > arrow_python-tests = 0.45 sec*proc (1 test) > > > > filesystem = 6.36 sec*proc (2 tests) > > > > parquet-tests = 7.22 sec*proc (7 tests) > > > > unittest = 79.41 sec*proc (52 tests) > > > > > > > > Total Test time (real) = 80.27 sec > > > > > > > > The following tests FAILED: > > > > 45 - arrow-python-test (Failed) > > > > 46 - parquet-internals-test (Failed) > > > > 49 - parquet-arrow-test (Failed) > > > > Errors while running CTest > > > > > > > > I don't know if this has any significance, I got the errors from 2 > runs. > > > > > > > > Neville > > > > > > > > On Fri, 22 Jan 2021 at 14:22, Neville Dipale <nevilled...@gmail.com> > > > wrote: > > > > > > > > > This is my first time verifying, do I also need to set the env vars > > > below? > > > > > > > > > > ARROW_GANDIVA=0 ARROW_PLASMA=0 TEST_DEFAULT=0 > > > > > TEST_SOURCE=1 TEST_CPP=1 TEST_PYTHON=1 TEST_JAVA=1 > > > > > TEST_INTEGRATION_CPP=1 TEST_INTEGRATION_JAVA=1 > > > > > > > > > > Otherwise, I'm currently running: > > > > > ./dev/release/verify-release-candidate.bat 3.0.0 2 > > > > > > > > > > Though it looks like it wants Visual Studio 2017. I should already > have > > > > > the build tools because I need them for Rust, so the error's odd. > I'll > > > keep > > > > > debugging my environment, and revert back if I'm able to > successfully > > > > > verify > > > > > on Windows. > > > > > > > > > > Neville > > > > > > > > > > On Fri, 22 Jan 2021 at 11:45, Krisztián Szűcs < > > > szucs.kriszt...@gmail.com> > > > > > wrote: > > > > > > > > > >> Could anyone verify the release on a windows machine? > > > > >> > > > > >> On Thu, Jan 21, 2021 at 4:43 AM Bryan Cutler <cutl...@gmail.com> > > > wrote: > > > > >> > > > > > >> > +1 (non-binding) > > > > >> > > > > > >> > I verified binaries and source with the following: > > > > >> > ARROW_TMPDIR=/tmp/arrow-test ARROW_GANDIVA=0 ARROW_PLASMA=0 > > > > >> TEST_DEFAULT=0 > > > > >> > TEST_SOURCE=1 TEST_CPP=1 TEST_PYTHON=1 TEST_JAVA=1 > > > > >> TEST_INTEGRATION_CPP=1 > > > > >> > TEST_INTEGRATION_JAVA=1 dev/release/verify-release-candidate.sh > > > source > > > > >> > 3.0.0 2 > > > > >> > > > > > >> > I also have Spark integration tests passing in PR > > > > >> > https://github.com/apache/arrow/pull/9210 > > > > >> > > > > > >> > On Wed, Jan 20, 2021 at 12:48 PM Sutou Kouhei < > k...@clear-code.com> > > > > >> wrote: > > > > >> > > > > > >> > > +1 (binding) > > > > >> > > > > > > >> > > I ran the followings on Debian GNU/Linux sid: > > > > >> > > > > > > >> > > * TZ=UTC \ > > > > >> > > ARROW_CMAKE_OPTIONS="-DBoost_NO_BOOST_CMAKE=ON" \ > > > > >> > > CUDA_TOOLKIT_ROOT=/usr \ > > > > >> > > dev/release/verify-release-candidate.sh source 3.0.0 2 > > > > >> > > * dev/release/verify-release-candidate.sh binaries 3.0.0 2 > > > > >> > > * LANG=C dev/release/verify-release-candidate.sh wheels > 3.0.0 2 > > > > >> > > > > > > >> > > with: > > > > >> > > > > > > >> > > * gcc (Debian 10.2.1-6) 10.2.1 20210110 > > > > >> > > * openjdk version "11.0.10-ea" 2021-01-19 > > > > >> > > * nvidia-cuda-dev 11.1.1-3 > > > > >> > > > > > > >> > > Thanks, > > > > >> > > -- > > > > >> > > kou > > > > >> > > > > > > >> > > In <CAHM19a5c47F--rxMT90YqWYSZ2AtKpbWpA= > > > > >> geq7psj25mtp...@mail.gmail.com> > > > > >> > > "[VOTE] Release Apache Arrow 3.0.0 - RC2" on Tue, 19 Jan > 2021 > > > > >> 04:49:13 > > > > >> > > +0100, > > > > >> > > Krisztián Szűcs <ksz...@apache.org> wrote: > > > > >> > > > > > > >> > > > Hi, > > > > >> > > > > > > > >> > > > I would like to propose the following release candidate > (RC2) of > > > > >> Apache > > > > >> > > > Arrow version 3.0.0. This is a release consisting of 678 > > > > >> > > > resolved JIRA issues[1]. > > > > >> > > > > > > > >> > > > This release candidate is based on commit: > > > > >> > > > d613aa68789288d3503dfbd8376a41f2d28b6c9d [2] > > > > >> > > > > > > > >> > > > The source release rc2 is hosted at [3]. > > > > >> > > > The binary artifacts are hosted at [4][5][6][7]. > > > > >> > > > The changelog is located at [8]. > > > > >> > > > > > > > >> > > > Please download, verify checksums and signatures, run the > unit > > > > >> tests, > > > > >> > > > and vote on the release. See [9] for how to validate a > release > > > > >> candidate. > > > > >> > > > > > > > >> > > > The vote will be open for at least 72 hours. > > > > >> > > > > > > > >> > > > [ ] +1 Release this as Apache Arrow 3.0.0 > > > > >> > > > [ ] +0 > > > > >> > > > [ ] -1 Do not release this as Apache Arrow 3.0.0 because... > > > > >> > > > > > > > >> > > > [1]: > > > > >> > > > > > > >> > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%203.0.0 > > > > >> > > > [2]: > > > > >> > > > > > > >> > > > > https://github.com/apache/arrow/tree/d613aa68789288d3503dfbd8376a41f2d28b6c9d > > > > >> > > > [3]: > > > > >> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-3.0.0-rc2 > > > > >> > > > [4]: https://bintray.com/apache/arrow/centos-rc/3.0.0-rc2 > > > > >> > > > [5]: https://bintray.com/apache/arrow/debian-rc/3.0.0-rc2 > > > > >> > > > [6]: https://bintray.com/apache/arrow/python-rc/3.0.0-rc2 > > > > >> > > > [7]: https://bintray.com/apache/arrow/ubuntu-rc/3.0.0-rc2 > > > > >> > > > [8]: > > > > >> > > > > > > >> > > > > https://github.com/apache/arrow/blob/d613aa68789288d3503dfbd8376a41f2d28b6c9d/CHANGELOG.md > > > > >> > > > [9]: > > > > >> > > > > > > >> > > > > https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates > > > > >> > > > > > > >> > > > > > > > > >
