Since we're on the topic of improving the workflow I had a proposal to consider. Right now the review process is pretty ad-hoc which is fine but can be a bit tricky to keep track of.
I think it could be improved with a bot to label PRs. The labels would be... state: failing tests - Any PR starts in this state until either all tests pass or the submitter could say something like "please review" to bypass (e.g. in case an intermittent or unrelated test failed since non-committers are not able to rerun jobs). Add something to developer docs FAQ about this bypass. state: needs review - Once all tests pass a PR would move into this state. state: needs improvement - If someone makes a review with the "comment" or "request changes" action the PR moves into this state. To clear this state the user must click "re-request review". Add something to developer docs FAQ about this since it may be unintuitive. That's it. I'd be happy to create the bot if the community thinks it is a good idea. None of this would be required or authoritative. It's merely a label to help for tracking purposes. Reviewers could presumably use the tags to create some kind of dashboard showing which PRs need review and which have been waiting for review the longest. Even without that, it would serve to make it clear to the submitter and the reviewers where the action is. -Weston Pace
