Really good question, it should throw upon Builder() creation. The change in the PR fixes an exception when importing the Arrow lib. I'll test it later today or tomorrow.
Best regards, Adam Lippai On Wed, Apr 28, 2021 at 6:38 PM Dominik Moritz <domor...@cmu.edu> wrote: > Thank you for the pull request. > > I’m curious regarding, CSP (which restricts the use of eval), did you try > that Arrow 3 works? I’m wondering since Arrow already uses a Function > constructor in > > https://github.com/apache/arrow/blob/0d11014ee8e6ce408ddbbdfb788d901dd6c6374f/js/src/builder/valid.ts#L66 > . > > On Apr 28, 2021 at 00:55:27, Adam Lippai <a...@rigo.sk> wrote: > > > Hi, > > > > I'd want to propose including https://github.com/apache/arrow/pull/10181 > > in > > 4.0.1 release, if it happens. > > While the issue is barely a bugfix, it's still a minor regression since > > 3.0.0. It happens only in special circumstances, eg. using Rollup bundler > > or restricting eval() for security reasons. It doesn't warrant a new > > release on it's own as it affects a marginal fraction of the consumers > > only. > > > > The change shouldn't affect the API or the required NodeJS versions. > > > > Best regards, > > Adam Lippai > > >
