So, looking at the error message in the Go integration tests and looking at
the stack trace, I was able to confirm the bug. I'm not sure why it showed
up in that run but not subsequent / reproducible but the issue comes down
to the following:

In decimal128.go in the `FromBigInt` function you have this:

b := v.Bits()
> n.lo = uint64(b[0])
>

Turns out that if the passed in `v` is 0, then the length of b is also 0,
so this ends up attempting to access index 0 of an empty slice. Simple fix
being to return early with 0 if v.BitLen() == 0.

I've put up https://github.com/apache/arrow/pull/10796 to fix the issue.

On Sat, Jul 24, 2021 at 5:17 AM Yibo Cai <yibo....@arm.com> wrote:

> +1
>
> Verified C++ and Python on Arm64 Linux (Ubuntu 20.04, aarch64).
>
> ARROW_CMAKE_OPTIONS="-DCMAKE_CXX_COMPILER=/usr/bin/clang++-10
> -DCMAKE_C_COMPILER=/usr/bin/clang-10" TEST_DEFAULT=0 TEST_SOURCE=1
> TEST_CPP=1 TEST_PYTHON=1 dev/release/verify-release-candidate.sh source
> 5.0.0 1
>
> On 7/23/21 11:25 AM, Krisztián Szűcs wrote:
> > Hi,
> >
> > I would like to propose the following release candidate (RC1) of Apache
> > Arrow version 5.0.0. This is a release consisting of 551
> > resolved JIRA issues[1].
> >
> > This release candidate is based on commit:
> > 4591d76fce2846a29dac33bf01e9ba0337b118e9 [2]
> >
> > The source release rc1 is hosted at [3].
> > The binary artifacts are hosted at [4][5][6][7][8][9].
> > The changelog is located at [10].
> >
> > Please download, verify checksums and signatures, run the unit tests,
> > and vote on the release. See [11] for how to validate a release
> candidate.
> >
> > Note, please use [12] to verify the Amazon Linux and CentOS packages.
> >
> > The vote will be open for at least 72 hours.
> >
> > [ ] +1 Release this as Apache Arrow 5.0.0
> > [ ] +0
> > [ ] -1 Do not release this as Apache Arrow 5.0.0 because...
> >
> > [1]:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%205.0.0
> > [2]:
> https://github.com/apache/arrow/tree/4591d76fce2846a29dac33bf01e9ba0337b118e9
> > [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-5.0.0-rc1
> > [4]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/
> > [5]: https://apache.jfrog.io/artifactory/arrow/centos-rc/
> > [6]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
> > [7]: https://apache.jfrog.io/artifactory/arrow/nuget-rc/5.0.0-rc1
> > [8]: https://apache.jfrog.io/artifactory/arrow/python-rc/5.0.0-rc1
> > [9]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
> > [10]:
> https://github.com/apache/arrow/blob/4591d76fce2846a29dac33bf01e9ba0337b118e9/CHANGELOG.md
> > [11]:
> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
> > [12]: https://github.com/apache/arrow/pull/10786
> >
>

Reply via email to