Hi QP,

This looks great overall but I did run into one issue. The Ballista crates
have relative paths for dependencies rather than depending on versioned
crates, so we would not be able to publish them to crates.io

*$ find ballista -name Cargo.toml -exec grep -H "path" {} \;*
ballista/rust/scheduler/Cargo.toml:ballista-core = { path = "../core" }
ballista/rust/scheduler/Cargo.toml:datafusion = { path =
"../../../datafusion" }
ballista/rust/scheduler/Cargo.toml:ballista-core = { path = "../core" }
ballista/rust/executor/Cargo.toml:ballista-core = { path = "../core" }
ballista/rust/executor/Cargo.toml:datafusion = { path =
"../../../datafusion" }
ballista/rust/core/Cargo.toml:datafusion = { path = "../../../datafusion" }
ballista/rust/client/Cargo.toml:ballista-core = { path = "../core" }
ballista/rust/client/Cargo.toml:ballista-executor = { path = "../executor",
optional = true }
ballista/rust/client/Cargo.toml:ballista-scheduler = { path =
"../scheduler", optional = true }
ballista/rust/client/Cargo.toml:datafusion = { path = "../../../datafusion"
}

I assume this is relatively simple to fix. I can look into this more later
today.

Thanks,

Andy.

On Tue, Aug 10, 2021 at 2:48 PM QP Hou <ho...@apache.org> wrote:

> Hi,
>
> I would like to propose a release of Apache Arrow Datafusion
> Implementation,
> version 5.0.0.
>
> This release candidate is based on commit:
> 96658eb100436c47601ed10095d74299d2229020 [1]
> The proposed release tarball and signatures are hosted at [2].
> The changelog is located at [3].
>
> Please download, verify checksums and signatures, run the unit tests, and
> vote
> on the release. The vote will be open for at least 72 hours.
>
> [ ] +1 Release this as Apache Arrow Datafusion
> [ ] +0
> [ ] -1 Do not release this as Apache Arrow Datafusion  because...
>
> [1]:
> https://github.com/apache/arrow-datafusion/tree/96658eb100436c47601ed10095d74299d2229020
> [2]:
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-5.0.0-rc1
> [3]:
> https://github.com/apache/arrow-datafusion/blob/96658eb100436c47601ed10095d74299d2229020/CHANGELOG.md
>
> Thanks,
> QP
>

Reply via email to