On Wed, 25 Aug 2021 at 17:21, Antoine Pitrou <anto...@python.org> wrote:
> > Le 25/08/2021 à 17:12, Joris Van den Bossche a écrit : > > One example of consumer of our Cython API is cudf ( > > https://github.com/rapidsai/cudf). > > I am not very familiar with the package itself, but browsing its code, I > > see that they do for example cimport RecordBatchReader ( > > > https://github.com/rapidsai/cudf/blob/f6d31fa95d9b8d8658301438d0f9ba22a1c131aa/python/cudf/cudf/_lib/gpuarrow.pyx#L20 > ), > > a case that would be impacted by > https://github.com/apache/arrow/pull/10162 > > > > Another question: do we regard `from pyarrow.includes.* import xx` as > > public? > > Probably not, but there's no reason for those exports to disappear, either. > > > Example use case: https://github.com/rapidsai/cudf/blob/be25a30ca20f3135f341c51b36cb075b376d5def/python/cudf/cudf/_lib/cpp/io/types.pxd#L9 Here they are doing `from pyarrow.includes.libarrow cimport CRandomAccessFile` (CRandomAccessFile is the cython equivalent of a public C++ API, and thus also public?), but would we recommend `from pyarrow.lib cimport CRandomAccessFile` instead? Although for imports from `pyarrow.includes.libarrow_cuda` that would not be possible.
