Ok. Thanks for the feedback.

Javascript may have problems when using nohup

so directly running

env "TEST_DEFAULT=0" env "TEST_JS=1" bash dev/release/verify-release-candidate.sh source 6.0.0 3

seems to work, but

nohup env "TEST_DEFAULT=0" env "TEST_JS=1" bash dev/release/verify-release-candidate.sh source 6.0.0 3 > log.out &

may not work [1].

[1] https://stackoverflow.com/questions/16604176/error-ebadf-bad-file-descriptor-when-running-node-using-nohup-of-forever

On 10/26/21 2:32 PM, Krisztián Szűcs wrote:
Thanks Benson for verifying!

Created a jira to track the depreciation warnings [1] and seems like
you've already created a PR for the javascript issue [2].
Luckily, these issues are not blockers.

[1]: https://issues.apache.org/jira/browse/ARROW-14468
[2]: 
https://github.com/apache/arrow/commit/b4bc846fcdf189ae0443b8445c3ef69fc4131764


On Sat, Oct 23, 2021 at 1:59 AM Benson Muite <benson_mu...@emailplus.org> wrote:

on Ubuntu 20.04 x86

Checked sources (C++, Python, Java, Ruby, Glib, C#, Javascript)

bash dev/release/verify-release-candidate.sh source 6.0.0 3

gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
Ubuntu clang version
10.0.1-++20211003085942+ef32c611aa21-1~exp1~20211003090334.2
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux]
node v14.18.1
openjdk version "1.8.0_292"
Python 3.8.10

++, Python, Java, Ruby, Glib and C# pass tests. Get a failure with
Javascript, though this is likely a setup error on my part:

+ yarn run-s clean:all lint build
yarn run v1.22.17
$ /tmp/arrow-6.0.0.BDnN3/apache-arrow-6.0.0/js/node_modules/.bin/run-s
clean:all lint build
events.js:377
        throw er; // Unhandled 'error' event
        ^

Error: EBADF: bad file descriptor, read
Emitted 'error' event on ReadStream instance at:
      at internal/fs/streams.js:173:14
      at FSReqCallback.wrapper [as oncomplete] (fs.js:562:5) {
    errno: -9,
    code: 'EBADF',
    syscall: 'read'
}
error Command failed with exit code 1.


When running the tests directly in arrow/js using

nvm install --lts
npm install -g yarn
yarn --forzen-lockfile
yarn run-s clean:all lint build
yarn test

Tests pass.

There are some compilation warnings due to uninitialized variables and
due to deprecations, for example:

/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:
In function ‘PyObject*
__pyx_pf_7pyarrow_8_parquet_12FileMetaData_14format_version___get__(__pyx_obj_7pyarrow_8_parquet_FileMetaData*)’:
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:14168:36:
warning: ‘parquet::ParquetVersion::PARQUET_2_0’ is deprecated: use
PARQUET_2_4 or PARQUET_2_6 for fine-grained feature selection
[-Wdeprecated-declarations]
14168 |     case  parquet::ParquetVersion::PARQUET_2_0:
        |                                    ^~~~~~~~~~~
In file included from
/tmp/arrow-6.0.0.theE2/install/include/parquet/types.h:30,
                   from
/tmp/arrow-6.0.0.theE2/install/include/parquet/schema.h:32,
                   from
/tmp/arrow-6.0.0.theE2/install/include/parquet/api/schema.h:21,
                   from
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:734:
/tmp/arrow-6.0.0.theE2/install/include/parquet/type_fwd.h:44:5: note:
declared here
     44 |     PARQUET_2_0 ARROW_DEPRECATED_ENUM_VALUE("use PARQUET_2_4 or
PARQUET_2_6 "
        |     ^~~~~~~~~~~
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:14168:36:
warning: ‘parquet::ParquetVersion::PARQUET_2_0’ is deprecated: use
PARQUET_2_4 or PARQUET_2_6 for fine-grained feature selection
[-Wdeprecated-declarations]
14168 |     case  parquet::ParquetVersion::PARQUET_2_0:
        |                                    ^~~~~~~~~~~
In file included from
/tmp/arrow-6.0.0.theE2/install/include/parquet/types.h:30,
                   from
/tmp/arrow-6.0.0.theE2/install/include/parquet/schema.h:32,
                   from
/tmp/arrow-6.0.0.theE2/install/include/parquet/api/schema.h:21,
                   from
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:734:
/tmp/arrow-6.0.0.theE2/install/include/parquet/type_fwd.h:44:5: note:
declared here
     44 |     PARQUET_2_0 ARROW_DEPRECATED_ENUM_VALUE("use PARQUET_2_4 or
PARQUET_2_6 "
        |     ^~~~~~~~~~~
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:
In function ‘std::shared_ptr<parquet::WriterProperties>
__pyx_f_7pyarrow_8_parquet__create_writer_properties(__pyx_opt_args_7pyarrow_8_parquet__create_writer_properties*)’:
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:23800:62:
warning: ‘parquet::ParquetVersion::PARQUET_2_0’ is deprecated: use
PARQUET_2_4 or PARQUET_2_6 for fine-grained feature selection
[-Wdeprecated-declarations]
23800 |       (void)(__pyx_v_props.version(
parquet::ParquetVersion::PARQUET_2_0));
        |
^~~~~~~~~~~
In file included from
/tmp/arrow-6.0.0.theE2/install/include/parquet/types.h:30,
                   from
/tmp/arrow-6.0.0.theE2/install/include/parquet/schema.h:32,
                   from
/tmp/arrow-6.0.0.theE2/install/include/parquet/api/schema.h:21,
                   from
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:734:
/tmp/arrow-6.0.0.theE2/install/include/parquet/type_fwd.h:44:5: note:
declared here
     44 |     PARQUET_2_0 ARROW_DEPRECATED_ENUM_VALUE("use PARQUET_2_4 or
PARQUET_2_6 "
        |     ^~~~~~~~~~~
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:23800:62:
warning: ‘parquet::ParquetVersion::PARQUET_2_0’ is deprecated: use
PARQUET_2_4 or PARQUET_2_6 for fine-grained feature selection
[-Wdeprecated-declarations]
23800 |       (void)(__pyx_v_props.version(
parquet::ParquetVersion::PARQUET_2_0));
        |
^~~~~~~~~~~
In file included from
/tmp/arrow-6.0.0.theE2/install/include/parquet/types.h:30,
                   from
/tmp/arrow-6.0.0.theE2/install/include/parquet/schema.h:32,
                   from
/tmp/arrow-6.0.0.theE2/install/include/parquet/api/schema.h:21,
                   from
/tmp/arrow-6.0.0.theE2/apache-arrow-6.0.0/python/build/temp.linux-x86_64-3.8/_parquet.cpp:734:
/tmp/arrow-6.0.0.theE2/install/include/parquet/type_fwd.h:44:5: note:
declared here
     44 |     PARQUET_2_0 ARROW_DEPRECATED_ENUM_VALUE("use PARQUET_2_4 or
PARQUET_2_6 "
        |     ^~~~~~~~~~~


On 10/22/21 6:46 PM, David Li wrote:
+1

Verified on Ubuntu 18.04 x86

Checked sources (C++, Python, Java), binaries, and wheels.
The FlightRPC tests initially failed in the wheels due to lack of test data.

-David

On Fri, Oct 22, 2021, at 08:15, Alessandro Molina wrote:
+1 (non binding)

Verified on Mac OS 10.14 x86

Checked
dev/release/verify-release-candidate.sh binaries 6.0.0 3
dev/release/verify-release-candidate.sh wheels 6.0.0 3

Only notice, I got a "OSError: [Errno 24] Too many open files" error
initially and had to raise limit over open files. I don't know if that's
expected or something changed recently.

On Fri, Oct 22, 2021 at 1:31 AM Krisztián Szűcs <szucs.kriszt...@gmail.com>
wrote:

Hi,

I would like to propose the following release candidate (RC3) of Apache
Arrow version 6.0.0. This is a release consisting of 592
resolved JIRA issues[1].

This release candidate is based on commit:
5a5f4ce326194750422ef6f053469ed1912ce69f [2]

The source release rc3 is hosted at [3].
The binary artifacts are hosted at [4][5][6][7][8][9].
The changelog is located at [10].

Please download, verify checksums and signatures, run the unit tests,
and vote on the release. See [11] for how to validate a release candidate.

The vote will be open for at least 72 hours.

[ ] +1 Release this as Apache Arrow 6.0.0
[ ] +0
[ ] -1 Do not release this as Apache Arrow 6.0.0 because...

[1]:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%206.0.0
[2]:
https://github.com/apache/arrow/tree/5a5f4ce326194750422ef6f053469ed1912ce69f
[3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-6.0.0-rc3
[4]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/
[5]: https://apache.jfrog.io/artifactory/arrow/centos-rc/
[6]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
[7]: https://apache.jfrog.io/artifactory/arrow/nuget-rc/6.0.0-rc3
[8]: https://apache.jfrog.io/artifactory/arrow/python-rc/6.0.0-rc3
[9]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
[10]:
https://github.com/apache/arrow/blob/5a5f4ce326194750422ef6f053469ed1912ce69f/CHANGELOG.md
[11]:
https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates





Reply via email to