+1 (binding) There are 3 test failures because the hardcoded strings expect "ARROW_TEST_DATA" but we get "privateARROW_TEST_DATA" when verifying the RC.
An example can be seen on this diff https://www.diffchecker.com/B8i8w4GC. My conclusion from looking at it is that it's likely a quirk that we can fix, but shouldn't affect the release. On Wed, 13 Jul 2022 at 23:48, QP Hou <q...@neuralink.com> wrote: > +1 (binding) > > On Wed, Jul 13, 2022 at 1:24 PM Andrew Lamb <al...@influxdata.com> wrote: > > > > +1 (binding) > > > > Thanks Andy! I know releases are a significant amount of work. > > > > Andrew > > > > On Tue, Jul 12, 2022 at 11:45 AM Andy Grove <andygrov...@gmail.com> > wrote: > > > > > Hi, > > > > > > I would like to propose a release of Apache Arrow DataFusion > > > Implementation, > > > version 10.0.0. > > > > > > This release candidate is based on commit: > > > d25e822c1ef85ee7c0297b4b38d05a51b0d2e46f [1] > > > The proposed release tarball and signatures are hosted at [2]. > > > The changelog is located at [3]. > > > > > > Please download, verify checksums and signatures, run the unit tests, > and > > > vote > > > on the release. The vote will be open for at least 72 hours. > > > > > > Only votes from PMC members are binding, but all members of the > community > > > are > > > encouraged to test the release and vote with "(non-binding)". > > > > > > The standard verification procedure is documented at > > > > > > > https://github.com/apache/arrow-datafusion/blob/master/dev/release/README.md#verifying-release-candidates > > > . > > > > > > [ ] +1 Release this as Apache Arrow DataFusion 10.0.0 > > > [ ] +0 > > > [ ] -1 Do not release this as Apache Arrow DataFusion 10.0.0 because... > > > > > > Here is my vote: > > > > > > +1 > > > > > > [1]: > > > > > > > https://github.com/apache/arrow-datafusion/tree/d25e822c1ef85ee7c0297b4b38d05a51b0d2e46f > > > [2]: > > > > > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-10.0.0-rc1 > > > [3]: > > > > > > > https://github.com/apache/arrow-datafusion/blob/d25e822c1ef85ee7c0297b4b38d05a51b0d2e46f/CHANGELOG.md > > > >
