+1 (non-binding) Verified on M1 Mac. Thanks, Andrew and Liang-Chi!
On Sun, 24 Jul 2022 at 00:19, L. C. Hsieh <vii...@gmail.com> wrote: > Hi, Remzi > > You can change the following system setting to increase the maximum > number of open files: > ulimit -n 10240 > > Then it should work. > > On Sat, Jul 23, 2022 at 1:40 AM Remzi Yang <1371656737...@gmail.com> > wrote: > > > > Unfortunately, I met 2 test failures when verifying on M1 Mac using the > > script. > > ``` > > > > failures: > > > > > > ---- file::serialized_reader::tests::test_peek_page_with_dictionary_page > > stdout ---- > > > > thread > > 'file::serialized_reader::tests::test_peek_page_with_dictionary_page' > > panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 24, > > kind: Uncategorized, message: "Too many open files" }', > > parquet/src/util/io.rs:84:50 > > > > > > ---- file::serialized_reader::tests::test_skip_page_with_offset_index > > stdout ---- > > > > thread 'file::serialized_reader::tests::test_skip_page_with_offset_index' > > panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 24, > > kind: Uncategorized, message: "Too many open files" }', > > parquet/src/util/io.rs:84:50 > > > > > > > > failures: > > > > file::serialized_reader::tests::test_peek_page_with_dictionary_page > > > > file::serialized_reader::tests::test_skip_page_with_offset_index > > > > > > test result: FAILED. 550 passed; 2 failed; 0 ignored; 0 measured; 0 > > filtered out; finished in 4.01s > > > > > > *error**:* test failed, to rerun pass '-p parquet --lib' > > > > + cleanup > > > > + '[' no = yes ']' > > > > + echo 'Failed to verify release candidate. See > > > /var/folders/84/nsymn7_12zx6vf8yx8hkxssw0000gq/T/arrow-19.0.0.XXXXX.UHJn9zes > > for details.' > > > > Failed to verify release candidate. See > > > /var/folders/84/nsymn7_12zx6vf8yx8hkxssw0000gq/T/arrow-19.0.0.XXXXX.UHJn9zes > > for details. > > ``` > > > > On Sat, 23 Jul 2022 at 14:02, QP Hou <q...@neuralink.com> wrote: > > > > > +1 (binding) > > > > > > On Fri, Jul 22, 2022 at 5:01 PM L. C. Hsieh <vii...@gmail.com> wrote: > > > > > > > > +1 (non-binding) > > > > > > > > Tested on Intel Macbook. > > > > > > > > Thanks Andrew! > > > > > > > > On Fri, Jul 22, 2022 at 12:34 PM Ian Joiner <iajoiner...@gmail.com> > > > wrote: > > > > > > > > > > +1 (Non-binding) > > > > > > > > > > Tested on a MacBook Pro with macOS 12.2.1 & Apple M1 Pro chip > > > > > > > > > > On Fri, Jul 22, 2022 at 12:56 PM Andrew Lamb <al...@influxdata.com > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > I would like to propose a release of Apache Arrow Rust > > > Implementation, > > > > > > version 19.0.0. > > > > > > > > > > > > This release candidate is based on commit: > > > > > > c3e019f3011a902a344758969b1cfc3604f3c2d7 [1] > > > > > > > > > > > > The proposed release tarball and signatures are hosted at [2]. > > > > > > > > > > > > The changelog is located at [3]. > > > > > > > > > > > > Please download, verify checksums and signatures, run the unit > tests, > > > > > > and vote on the release. There is a script [4] that automates > some of > > > > > > the verification. > > > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > > > [ ] +1 Release this as Apache Arrow Rust > > > > > > [ ] +0 > > > > > > [ ] -1 Do not release this as Apache Arrow Rust because... > > > > > > > > > > > > [1]: > > > > > > > > > > > > > > > > https://github.com/apache/arrow-rs/tree/c3e019f3011a902a344758969b1cfc3604f3c2d7 > > > > > > [2]: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-rs-19.0.0-rc1 > > > > > > [3]: > > > > > > > > > > > > > > > > https://github.com/apache/arrow-rs/blob/c3e019f3011a902a344758969b1cfc3604f3c2d7/CHANGELOG.md > > > > > > [4]: > > > > > > > > > > > > > > > > https://github.com/apache/arrow-rs/blob/master/dev/release/verify-release-candidate.sh > > > > > > --------------------------------------------------------- > > > > > > > > > >