Updating with master fixed it, thanks.
Yaron. ________________________________ From: Antoine Pitrou <anto...@python.org> Sent: Thursday, September 22, 2022 4:28 AM To: dev@arrow.apache.org <dev@arrow.apache.org> Subject: Re: unclear compilation errors with util::optional Hi Yaron, On git master we recently moved to C++17 and therefore removed compatibility backports such as arrow::util::optional. Now you should just use std::optional. So be sure to rebase your work on master and fix any reference to those compatibility backports in your code. Regards Antoine. Le 22/09/2022 à 10:26, Yaron Gvili a écrit : > Hi, > > In a PR I'm working on [1], I get compilation errors in CI jobs that I don't > see the reason for. I'd appreciate help with this. > > For example, one job's [2] compilation complains about the util::optional > symbol not being declared (this happens in other jobs too). This is unclear > for a couple of reasons. AFAICS, the source_node.cc being compiled does have > the right include for this symbol and uses it appropriately from within the > arrow namespace. This source_node.cc compiles cleanly in my local repo, and > previously this never led to errors like this in CI, so likely some change > (which?) besides my code changes in this PR is involved in this. Also, the > util::optional symbol appears elsewhere in source_node.cc and the job's > compilation does not complain on these occurrences. > > [1] https://github.com/apache/arrow/pull/14041 > [2] https://github.com/apache/arrow/actions/runs/3100937214/jobs/5021759834 > > > Cheers, > Yaron. >
