non-binding. Minor verification errors.
Environment:
CentOS 7
clang version 13.0.1 (Red Hat 13.0.1-1.el7_9)
Target: x86_64-redhat-linux-gnu
gcc (GCC) 11.2.1 20220127 (Red Hat 11.2.1-9)
OpenSSL 1.0 or OpenSSL 3.0
When examining commit 89f9a0948961f6e94f1ef5e4f310b707d22a3c11 or
release candidate 10.0.0 - RC0 sources, Gandiva fails to build with
OpenSSL 1.0. From within the arrow repository:
$ export TEST_DEFAULT=0
$ export TEST_SOURCE=1
$ dev/release/verify-release-candidate.sh
[ 60%] Building CXX object
src/gandiva/CMakeFiles/gandiva_objlib.dir/hash_utils.cc.o
/root/arrow/cpp/src/gandiva/hash_utils.cc: In function ‘const char*
gandiva::gdv_hash_using_openssl(int64_t, const void*, size_t, const
EVP_MD*, uint32_t, int32_t*)’:
/root/arrow/cpp/src/gandiva/hash_utils.cc:70:24: error: ‘EVP_MD_CTX_new’
was not declared in this scope; did you mean ‘EVP_MD_CTX_md’?
70 | EVP_MD_CTX* md_ctx = EVP_MD_CTX_new();
| ^~~~~~~~~~~~~~
| EVP_MD_CTX_md
/root/arrow/cpp/src/gandiva/hash_utils.cc:85:5: error: ‘EVP_MD_CTX_free’
was not declared in this scope; did you mean ‘EVP_MD_CTX_create’?
85 | EVP_MD_CTX_free(md_ctx);
| ^~~~~~~~~~~~~~~
| EVP_MD_CTX_create
/root/arrow/cpp/src/gandiva/hash_utils.cc:97:5: error: ‘EVP_MD_CTX_free’
was not declared in this scope; did you mean ‘EVP_MD_CTX_create’?
97 | EVP_MD_CTX_free(md_ctx);
| ^~~~~~~~~~~~~~~
| EVP_MD_CTX_create
/root/arrow/cpp/src/gandiva/hash_utils.cc:108:5: error:
‘EVP_MD_CTX_free’ was not declared in this scope; did you mean
‘EVP_MD_CTX_create’?
108 | EVP_MD_CTX_free(md_ctx);
| ^~~~~~~~~~~~~~~
| EVP_MD_CTX_create
/root/arrow/cpp/src/gandiva/hash_utils.cc:122:5: error:
‘EVP_MD_CTX_free’ was not declared in this scope; did you mean
‘EVP_MD_CTX_create’?
122 | EVP_MD_CTX_free(md_ctx);
| ^~~~~~~~~~~~~~~
| EVP_MD_CTX_create
/root/arrow/cpp/src/gandiva/hash_utils.cc:139:3: error:
‘EVP_MD_CTX_free’ was not declared in this scope; did you mean
‘EVP_MD_CTX_create’?
139 | EVP_MD_CTX_free(md_ctx);
| ^~~~~~~~~~~~~~~
| EVP_MD_CTX_create
gmake[2]: *** [src/gandiva/CMakeFiles/gandiva_objlib.dir/build.make:485:
src/gandiva/CMakeFiles/gandiva_objlib.dir/hash_utils.cc.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:7946:
src/gandiva/CMakeFiles/gandiva_objlib.dir/all] Error 2
With a source build of OpenSSL3.0.2, Gandiva does build, but the
following tests fail:
/root/apache-arrow-10.0.0/cpp/src/arrow/util/value_parsing_test.cc:805:
Failure
Expected equality of these values:
expected
Which is: 1514769420
converted
Which is: 1514769408
Google Test trace:
/root/apache-arrow-10.0.0/cpp/src/arrow/util/value_parsing_test.cc:800:
2018-01-01 00:00:00-0117
[ FAILED ] TimestampParser.StrptimeZoneOffset (0 ms)
/root/apache-arrow-10.0.0/cpp/src/arrow/flight/sql/server_test.cc:329:
Failure
Failed
'_error_or_value59.status()' failed with Invalid: Can't prepare
statement: near "(": syntax error. gRPC client debug context:
{"created":"@1666547640.550873050","description":"Error received from
peer
ipv6:[::1]:41650","file":"/tmp/arrow-HEAD.bOtfP/cpp-build/grpc_ep-prefix/src/grpc_ep/src/core/lib/surface/call.cc","file_line":952,"grpc_message":"Can't
prepare statement: near "(": syntax error","grpc_status":3}. Client
context: OK
[ FAILED ] TestFlightSqlServer.TestCommandGetTablesWithIncludedSchemas
(12 ms)
/root/apache-arrow-10.0.0/cpp/src/arrow/flight/sql/server_test.cc:618:
Failure
Failed
'_error_or_value104.status()' failed with Invalid: Can't prepare
statement: near "(": syntax error. gRPC client debug context:
{"created":"@1666547640.649382989","description":"Error received from
peer
ipv6:[::1]:38451","file":"/tmp/arrow-HEAD.bOtfP/cpp-build/grpc_ep-prefix/src/grpc_ep/src/core/lib/surface/call.cc","file_line":952,"grpc_message":"Can't
prepare statement: near "(": syntax error","grpc_status":3}. Client
context: IOError: Server never sent a data message. Detail: Internal
[ FAILED ] TestFlightSqlServer.TestCommandGetPrimaryKeys (15 ms)
/root/apache-arrow-10.0.0/cpp/src/arrow/flight/sql/server_test.cc:642:
Failure
Failed
'_error_or_value107.status()' failed with Invalid: Can't prepare
statement: near "(": syntax error. gRPC client debug context:
{"created":"@1666547640.653859201","description":"Error received from
peer
ipv6:[::1]:38210","file":"/tmp/arrow-HEAD.bOtfP/cpp-build/grpc_ep-prefix/src/grpc_ep/src/core/lib/surface/call.cc","file_line":952,"grpc_message":"Can't
prepare statement: near "(": syntax error","grpc_status":3}. Client
context: IOError: Server never sent a data message. Detail: Internal
[ FAILED ] TestFlightSqlServer.TestCommandGetImportedKeys (4 ms)
/root/apache-arrow-10.0.0/cpp/src/arrow/flight/sql/server_test.cc:674:
Failure
Failed
'_error_or_value110.status()' failed with Invalid: Can't prepare
statement: near "(": syntax error. gRPC client debug context:
{"created":"@1666547640.657013835","description":"Error received from
peer
ipv6:[::1]:36523","file":"/tmp/arrow-HEAD.bOtfP/cpp-build/grpc_ep-prefix/src/grpc_ep/src/core/lib/surface/call.cc","file_line":952,"grpc_message":"Can't
prepare statement: near "(": syntax error","grpc_status":3}. Client
context: IOError: Server never sent a data message. Detail: Internal
[ FAILED ] TestFlightSqlServer.TestCommandGetExportedKeys (5 ms)
/root/apache-arrow-10.0.0/cpp/src/arrow/flight/sql/server_test.cc:708:
Failure
Failed
'_error_or_value113.status()' failed with Invalid: Can't prepare
statement: near "(": syntax error. gRPC client debug context:
{"created":"@1666547640.662347626","description":"Error received from
peer
ipv6:[::1]:43394","file":"/tmp/arrow-HEAD.bOtfP/cpp-build/grpc_ep-prefix/src/grpc_ep/src/core/lib/surface/call.cc","file_line":952,"grpc_message":"Can't
prepare statement: near "(": syntax error","grpc_status":3}. Client
context: IOError: Server never sent a data message. Detail: Internal
[ FAILED ] TestFlightSqlServer.TestCommandGetCrossReference (3 ms)
On 10/23/22 10:31, Benson Muite wrote:
WIP but source verification fails for me on CentOS 7 due to unsigned key
from Neville Dipale:
TEST_DEFAULT=0 TEST_SOURCE=1 dev/release/verify-release-candidate.sh
10.0.0 0
....
gpg: key 717D3FB2: no valid user IDs
gpg: this may be caused by a missing self-signature
...
gpg: Total number processed: 14
gpg: w/o user IDs: 1
gpg: unchanged: 13
Failed to verify release candidate. See /tmp/arrow-10.0.0.gOoKw for
details.
On 10/22/22 22:32, David Li wrote:
Still WIP for me. Verified:
- C++, Python, Java, binaries on Ubuntu Linux 18.04/AMD64
- C++, Python, Java on MacOS 12.3/AArch64
* MacOS required Rosetta installed to generate Protobuf sources for Java
* I needed https://github.com/apache/arrow/pull/14477 to verify APT
packages on Linux
* I needed https://github.com/apache/arrow/pull/14479 to verify native
wheels on MacOS
I cannot verify universal2 wheels on MacOS as the binaries are for
macosx_10_14 but the script hardcodes macosx_11_0. And if I edit the
filename in the script, I get "...macosx_10_14_universal2.whl is not a
supported wheel on this platform". Is this intended?
On Fri, Oct 21, 2022, at 14:01, Jacob Wujciak wrote:
+1 (non-binding) verified on Manjaro with CUDA:
TEST_DEFAULT=0 \
TEST_SOURCE=0 \
TEST_INTEGRATION_CPP=1 \
TEST_CPP=1 \
TEST_PYTHON=1 \
dev/release/verify-release-candidate.sh 10.0.0 0
TEST_DEFAULT=0 \
TEST_SOURCE=0 \
TEST_BINARY=1 \
dev/release/verify-release-candidate.sh 10.0.0 0
with:
gcc 12.2.2
cuda_11.7.r11.7/compiler.31442593_0
python 3.10.7
Thanks!
On Fri, Oct 21, 2022 at 8:07 AM Sutou Kouhei <k...@clear-code.com> wrote:
Hi,
I would like to propose the following release candidate (RC0) of Apache
Arrow version 10.0.0. This is a release consisting of 470
resolved JIRA issues[1].
This release candidate is based on commit:
89f9a0948961f6e94f1ef5e4f310b707d22a3c11 [2]
The source release rc0 is hosted at [3].
The binary artifacts are hosted at [4][5][6][7][8][9][10][11].
The changelog is located at [12].
Please download, verify checksums and signatures, run the unit tests,
and vote on the release. See [13] for how to validate a release
candidate.
See also a verification result on GitHub pull request [14].
The vote will be open for at least 72 hours.
[ ] +1 Release this as Apache Arrow 10.0.0
[ ] +0
[ ] -1 Do not release this as Apache Arrow 10.0.0 because...
[1]:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20ARROW%20AND%20status%20in%20%28Resolved%2C%20Closed%29%20AND%20fixVersion%20%3D%2010.0.0
[2]:
https://github.com/apache/arrow/tree/89f9a0948961f6e94f1ef5e4f310b707d22a3c11
[3]:
https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-10.0.0-rc0
[4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/
[5]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/
[6]: https://apache.jfrog.io/artifactory/arrow/centos-rc/
[7]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
[8]: https://apache.jfrog.io/artifactory/arrow/java-rc/10.0.0-rc0
[9]: https://apache.jfrog.io/artifactory/arrow/nuget-rc/10.0.0-rc0
[10]: https://apache.jfrog.io/artifactory/arrow/python-rc/10.0.0-rc0
[11]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
[12]:
https://github.com/apache/arrow/blob/89f9a0948961f6e94f1ef5e4f310b707d22a3c11/CHANGELOG.md
[13]:
https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
[14]: https://github.com/apache/arrow/pull/14466
