The tag is created as part of the post release process (IIRC this is the same as the main Arrow process)
On Tue, Dec 27, 2022, at 17:29, Matt Topol wrote: > Will the updated scripts also create the proper GitHub tag for a Go release? > > On Tue, Dec 27, 2022, 5:11 PM Will Jones <will.jones...@gmail.com> wrote: > >> Thanks for the info Kou. Then I am +1 (non-binding). >> >> On Tue, Dec 27, 2022 at 2:09 PM Sutou Kouhei <k...@clear-code.com> wrote: >> >> > Hi, >> > >> > > On MacOS M1, the debian package tests fail with (similar issue with >> YUM): >> > > >> > > + apt install -y -V --no-install-recommends >> > libadbc-driver-manager-dev=0.1.0-1 >> > > E: Unable to locate package libadbc-driver-manager-dev >> > > Failed to verify the APT repository for debian:bullseye >> > > Failed to verify release candidate. >> > >> > > *Should that be blocking? I am not sure what the underlying issue is.* >> > >> > No. It's expected. >> > >> > ADBC 0.1.0 provides deb/rpm packages only for x86_64. >> > If we run the verification script without >> > DOCKER_DEFAULT_ARCHITECTURE on macOS M1, arm64 is used. It >> > requires deb/rpm packages for arm64. Then the verification >> > is failed. >> > >> > See also the David's note in the original vote email: >> > >> > >> > Note: to verify APT/YUM packages on macOS/AArch64, you >> > >> > must `export >> > >> > DOCKER_DEFAULT_ARCHITECTURE=linux/amd64`. (Or skip this >> > >> > step by `export TEST_APT=0 TEST_YUM=0`.) >> > >> > >> > Thanks, >> > -- >> > kou >> > >> > In <CAH6BBm2GjMvVkBumxZ7f+UPm-OkydXzqJZyLMbPSa6QHFJ1O=g...@mail.gmail.com> >> > "Re: [VOTE] Release Apache Arrow ADBC 0.1.0 - RC6" on Tue, 27 Dec 2022 >> > 13:48:49 -0800, >> > Will Jones <will.jones...@gmail.com> wrote: >> > >> > > Verified on MacOS M1 and Ubuntu 20.04 WSL. >> > > >> > > On MacOS M1, successfully ran: >> > > >> > > USE_CONDA=1 TEST_YUM=0 TEST_APT=0 >> > > dev/release/verify-release-candidate.sh 0.1.0 6 >> > > >> > > On MacOS M1, the debian package tests fail with (similar issue with >> YUM): >> > > >> > > + apt install -y -V --no-install-recommends >> > > libadbc-driver-manager-dev=0.1.0-1 >> > > E: Unable to locate package libadbc-driver-manager-dev >> > > Failed to verify the APT repository for debian:bullseye >> > > Failed to verify release candidate. See >> > > >> > >> /var/folders/_j/yjml4_wj3gvgk595bxmjdp9w0000gn/T/arrow-adbc-0.1.0.XXXXX.dww38Nle >> > > for details >> > > >> > > *Should that be blocking? I am not sure what the underlying issue is.* >> > > >> > > Ubuntu 20.04 doesn't have a new enough CURL to support the >> > > --retry-all-errors options added in [1]. If I replace it with changes >> in >> > > [2], and replace all pip invocations with python -m pip (I think >> that's a >> > > problem for me), it works. >> > > >> > > USE_CONDA=1 dev/release/verify-release-candidate.sh 0.1.0 6 >> > > >> > > [1] https://github.com/apache/arrow/pull/15090 >> > > [2] https://github.com/apache/arrow/pull/15099 >> > > >> > > >> > > >> > > On Mon, Dec 26, 2022 at 10:38 PM Sutou Kouhei <k...@clear-code.com> >> > wrote: >> > > >> > >> +1 >> > >> >> > >> I ran the following on Debian GNU/Linux sid: >> > >> >> > >> dev/release/verify-release-candidate.sh 0.1.0 6 >> > >> >> > >> with: >> > >> >> > >> * Python 3.10.8 >> > >> * g++ (Debian 12.2.0-9) 12.2.0 >> > >> * openjdk version "17.0.5" 2022-10-18 >> > >> * ruby 3.0.4p208 (2022-04-12 revision 3fa771dded) [x86_64-linux-gnu] >> > >> >> > >> Note: I need to improve the verification scripts to run on >> > >> my environments: >> > >> >> > >> * https://github.com/apache/arrow-adbc/pull/294 >> > >> * https://github.com/apache/arrow-adbc/pull/296 >> > >> * https://github.com/apache/arrow-adbc/pull/298 >> > >> * https://github.com/apache/arrow-adbc/pull/300 >> > >> * https://github.com/apache/arrow-adbc/pull/302 >> > >> >> > >> Thanks, >> > >> -- >> > >> kou >> > >> >> > >> In <74ef7d7e-55a3-4d28-bebb-b9842842c...@app.fastmail.com> >> > >> "[VOTE] Release Apache Arrow ADBC 0.1.0 - RC6" on Mon, 26 Dec 2022 >> > >> 10:55:24 -0500, >> > >> "David Li" <lidav...@apache.org> wrote: >> > >> >> > >> > Hello, >> > >> > >> > >> > I would like to propose the following release candidate (RC0) of >> > Apache >> > >> Arrow ADBC version 0.1.0. This is a release consisting of 63 resolved >> > >> GitHub issues[1]. >> > >> > >> > >> > This release candidate is based on commit: >> > >> 618a2ff1c64a5e2e410e30c5a156409c96fd9dfc [2] >> > >> > >> > >> > The source release rc6 is hosted at [3]. >> > >> > The binary artifacts are hosted at [4][5][6][7][8]. >> > >> > The changelog is located at [9]. >> > >> > >> > >> > Please download, verify checksums and signatures, run the unit >> tests, >> > >> > and vote on the release. See [10] for how to validate a release >> > >> candidate. >> > >> > >> > >> > See also a verification result on GitHub Actions [11]. >> > >> > >> > >> > The vote will be open for at least 72 hours. >> > >> > >> > >> > [ ] +1 Release this as Apache Arrow ADBC 0.1.0 >> > >> > [ ] +0 >> > >> > [ ] -1 Do not release this as Apache Arrow ADBC 0.1.0 because... >> > >> > >> > >> > Note: to verify APT/YUM packages on macOS/AArch64, you must `export >> > >> DOCKER_DEFAULT_ARCHITECTURE=linux/amd64`. (Or skip this step by >> `export >> > >> TEST_APT=0 TEST_YUM=0`.) >> > >> > >> > >> > [1]: >> > >> >> > >> https://github.com/apache/arrow-adbc/issues?q=is%3Aissue+milestone%3A0.1.0+is%3Aclosed >> > >> > [2]: >> > >> >> > >> https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.1.0-rc6 >> > >> > [3]: >> > >> >> > >> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-adbc-0.1.0-rc6/ >> > >> > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ >> > >> > [5]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ >> > >> > [6]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ >> > >> > [7]: >> > >> >> > >> https://repository.apache.org/content/repositories/staging/org/apache/arrow/adbc/ >> > >> > [8]: >> > >> >> > >> https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.1.0-rc6 >> > >> > [9]: >> > >> >> > >> https://github.com/apache/arrow-adbc/blob/apache-arrow-adbc-0.1.0-rc6/CHANGELOG.md >> > >> > [10]: >> > >> >> > >> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates >> > >> > [11]: >> > >> >> > >> https://github.com/apache/arrow-adbc/actions/runs/3778956752/jobs/6423834271 >> > >> > >> > >> > Thanks Kou and Jacob for help preparing the release scripts and Kou >> > for >> > >> helping to prepare the release itself. >> > >> > >> > >> > -David >> > >> >> > >>
