+1 on only title Joris Van den Bossche <jorisvandenboss...@gmail.com> schrieb am Di., 31. Jan. 2023, 09:54:
> I would personally prefer to use just "Pull request title" instead of > "Pull request title and description". > > In my experience, including the description in the commit message (as > we already do) more often gives noise to the output of `git log`, and > you can always go from the commit to the PR to see the full context. > In many cases, the description is quite verbose or contain long > examples, or might be outdated (written when the PR was opened, but > the PR might have changed along the review process), ... Especially > now that we have the github PR template with sections, they might > become even more verbose. > > Personally, when opening a PR myself, I often leave the top post > empty, to add a second comment with more explanation, exactly to avoid > including that in the commit message if that doesn't seem useful to > me. > > Anyway, I am certainly OK with both options if the general consensus > is for "Pull request title and description" (and certainly if that > enables actually using the merge button), but just stating my personal > preference. > > On Tue, 31 Jan 2023 at 09:33, Raúl Cumplido <raulcumpl...@gmail.com> > wrote: > > > > +1 > > We already do it on the merge script and we have already changed it on > the > > `arrow-site` repo. > > > > El mar, 31 ene 2023 a las 9:13, Sutou Kouhei (<k...@clear-code.com>) > > escribió: > > > > > Hi, > > > > > > We need to get consensus to change the default commit > > > message for merge button: > > > > > > https://issues.apache.org/jira/browse/INFRA-24133 > > > > > > > Could you change the default commit message when merging a > > > > PR to "Default to pull request title and description" on > > > > the following Apache Arrow related repositories? > > > > > > > > * https://github.com/apache/arrow > > > > * https://github.com/apache/arrow-adbc > > > > * https://github.com/apache/arrow-cookbook > > > > * https://github.com/apache/arrow-flight-sql-postgresql > > > > * https://github.com/apache/arrow-julia > > > > * https://github.com/apache/arrow-nanoarrow > > > > * https://github.com/apache/arrow-testing > > > > > > > > See also: > > > > > > > > https://github.blog/changelog/2022-08-23-new-options-for-controlling-the-default-commit-message-when-merging-a-pull-request/ > > > > > > > > Related: https://issues.apache.org/jira/browse/INFRA-24122 > > > > > > https://issues.apache.org/jira/browse/INFRA-24133#comment-17682383 > > > > > > > Please provide a mailing list link to project consensus on this > change. > > > > > > > > > How about changing the default commit message for merge > > > button to "Default to pull request title and description" > > > like our dev/merge_arrow_pr.py in apache/arrow does? > > > > > > Note that this doesn't mean that we drop > > > dev/merge_arrow_pr.py immediately. It's a separated > > > discussion. > > > > > > > > > Thanks, > > > -- > > > kou > > > >
