I ran: ``` export DOCKER_DEFAULT_ARCHITECTURE=linux/amd64 export PKG_CONFIG_PATH=/opt/homebrew/Cellar/libpq/15.2/lib/pkgconfig/:/opt/homebrew/Cellar/openssl@3 /3.0.8/lib/pkgconfig/ export CGO_CXXFLAGS="-std=c++11" TEST_GLIB=0 ./dev/release/verify-release-candidate.sh 0.2.0 1 ```
I had to manually set the C++ standard for building the Go driver manager [1] and got a test failure in Python's SQLite driver [2]. The ruby gem red-arrow failed to install for me (first because it wanted sudo and second because of a linking error after I installed homebrew Ruby and added it to PATH). My familiarity is mostly with the C/C++ section of the repo since I can't speak to whether those issues are important or are artifacts of something in the MacOS default environment, I'm a non-binding +0. Cheers! -dewey [1] https://github.com/apache/arrow-adbc/issues/455 [2] https://github.com/apache/arrow-adbc/issues/456 On Mon, Feb 13, 2023 at 8:41 PM Matthew Topol <m...@voltrondata.com.invalid> wrote: > So I just ran it again this evening, without actually changing anything > that I'm aware of, and everything worked perfectly fine without any > issues... *shrug* > > I'm gonna take the win and vote +1 (non-binding) :) > > huzzah! > > On Sat, Feb 11, 2023 at 4:37 PM Sutou Kouhei <k...@clear-code.com> wrote: > > > Hi, > > > > Sorry. I missed this. It seems that GObject Introspection > > installed by conda is strange. > > > > Could you try the following? > > > > > > /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/g-ir-scanner > > --help > > > > I think that it reports the same error. > > > > Could you show the output of the following command line? > > _giscanner.cpython-311-x86_64-linux-gnu.so may not exist. > > > > ls -l > > > /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/gobject-introspection/giscanner/ > > > > > > Thanks, > > -- > > kou > > > > > > In <7c100a4e-ca12-4718-b213-b60271144...@app.fastmail.com> > > "Re: [VOTE] Release Apache Arrow ADBC 0.2.0 - RC1" on Sat, 11 Feb 2023 > > 12:16:58 -0500, > > "David Li" <lidav...@apache.org> wrote: > > > > > This looks like something got messed up when installing GLib > > dependencies, do you have an idea Kou? I wasn't able to reproduce it. > > > > > > On Fri, Feb 10, 2023, at 11:32, Matt Topol wrote: > > >> Ran into a problem running on Pop!_OS 22.04 LTS/amd64: > > >> > > >> TEST_APT=0 USE_CONDA=1 ./dev/release/verify-release-candidate.sh > 0.2.0 1 > > >> > > >>> Downloading and Extracting Packages > > >>> > > >>> Preparing transaction: done > > >>> Verifying transaction: done > > >>> Executing transaction: done > > >>> Bundler version 2.3.7 > > >>> The Meson build system > > >>> Version: 1.0.0 > > >>> Source dir: /tmp/arrow-adbc-0.2.0.YfcqT/apache-arrow-adbc-0.2.0/glib > > >>> Build dir: /tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib > > >>> Build type: native build > > >>> Project name: adbc-glib > > >>> Project version: 0.2.0 > > >>> C compiler for the host machine: > > >>> > > > /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/x86_64-conda-linux-gnu-cc > > >>> (gcc 11.3.0 "x86_64-conda-linux-gnu-cc (conda-forge gcc 11.3.0-19) > > 11.3.0") > > >>> C linker for the host machine: > > >>> > > > /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/x86_64-conda-linux-gnu-cc > > >>> ld.bfd 2.39 > > >>> Host machine cpu family: x86_64 > > >>> Host machine cpu: x86_64 > > >>> Found pkg-config: > > >>> > /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/pkg-config > > >>> (0.29.2) > > >>> Run-time dependency adbc-driver-manager found: YES 0.2.0 > > >>> Configuring version.h using configuration > > >>> Program glib-mkenums found: YES > > >>> > > > (/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/glib-mkenums) > > >>> Program glib-mkenums found: YES > > >>> > > > (/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/glib-mkenums) > > >>> Run-time dependency gobject-2.0 found: YES 2.74.1 > > >>> Run-time dependency gobject-introspection-1.0 found: YES 1.74.0 > > >>> Dependency gobject-introspection-1.0 found: YES 1.74.0 (cached) > > >>> Program g-ir-scanner found: YES > > >>> > > > (/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/g-ir-scanner) > > >>> Dependency gobject-introspection-1.0 found: YES 1.74.0 (cached) > > >>> Program g-ir-compiler found: YES > > >>> > > > (/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/g-ir-compiler) > > >>> Program ruby found: YES > > >>> (/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/ruby) > > >>> Build targets in project: 5 > > >>> adbc-glib 0.2.0 > > >>> > > >>> > > >>> User defined options > > >>> buildtype : debug > > >>> cmake_prefix_path: > > >>> > > > /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source:/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source:/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source:/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/x86_64-conda-linux-gnu/sysroot/usr > > >>> libdir : lib > > >>> pkg_config_path : > > >>> > > > /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/pkgconfig:/tmp/arrow-adbc-0.2.0.YfcqT/install/lib/pkgconfig:/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/pkgconfig > > >>> prefix : > > >>> /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source > > >> > > >> > > >>> Found ninja-1.11.0 at > > >>> /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/ninja > > >>> ninja: Entering directory > `/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib' > > >>> [9/10] Generating adbc-glib/ADBC-0.0.gir with a custom command > > (wrapped by > > >>> meson to set env) > > >>> FAILED: adbc-glib/ADBC-0.0.gir > > >>> env > > >>> > > > PKG_CONFIG_PATH=/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/pkgconfig:/tmp/arrow-adbc-0.2.0.YfcqT/install/lib/pkgconfig:/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/pkgconfig:/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib/meson-uninstalled > > >>> > > /tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/g-ir-scanner > > >>> --quiet --no-libtool --namespace=ADBC --nsversion=0.0 --warn-all > > --output > > >>> adbc-glib/ADBC-0.0.gir --c-include=adbc-glib/adbc-glib.h --warn-all > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/apache-arrow-adbc-0.2.0/glib/adbc-glib > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib/adbc-glib > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/apache-arrow-adbc-0.2.0/glib/. > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib/. > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/apache-arrow-adbc-0.2.0/glib/.. > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib/.. > > >>> > > > --filelist=/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib/adbc-glib/libadbc-glib.so.0.2.0.p/ADBC_0.0_gir_filelist > > >>> --include=GObject-2.0 --symbol-prefix=gadbc --identifier-prefix=GADBC > > >>> --pkg-export=adbc-glib --cflags-begin > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/apache-arrow-adbc-0.2.0/glib/. > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib/. > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/apache-arrow-adbc-0.2.0/glib/.. > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib/.. > > >>> -I/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/include > > >>> > > > -I/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/include/glib-2.0 > > >>> > > > -I/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/glib-2.0/include > > >>> > > > -I/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/include/gobject-introspection-1.0 > > >>> -DNDEBUG --cflags-end > > >>> > > > --add-include-path=/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/share/gir-1.0 > > >>> -L/tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib/adbc-glib --library > > adbc-glib > > >>> -L/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib > > >>> -L/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib > > >>> -ladbc_driver_manager -lgobject-2.0 -lglib-2.0 -lgirepository-1.0 > > >>> --warn-error > > >>> Traceback (most recent call last): > > >>> File > > >>> > > > "/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/bin/g-ir-scanner", > > >>> line 98, in <module> > > >>> from giscanner.scannermain import scanner_main > > >>> File > > >>> > > > "/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/gobject-introspection/giscanner/scannermain.py", > > >>> line 35, in <module> > > >>> from giscanner.ast import Include, Namespace > > >>> File > > >>> > > > "/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/gobject-introspection/giscanner/ast.py", > > >>> line 29, in <module> > > >>> from .sourcescanner import CTYPE_TYPEDEF, CSYMBOL_TYPE_TYPEDEF > > >>> File > > >>> > > > "/tmp/arrow-adbc-0.2.0.YfcqT/mambaforge/envs/conda-source/lib/gobject-introspection/giscanner/sourcescanner.py", > > >>> line 34, in <module> > > >>> from giscanner._giscanner import SourceScanner as CSourceScanner > > >>> ModuleNotFoundError: No module named 'giscanner._giscanner' > > >>> ninja: build stopped: subcommand failed. > > >>> Could not rebuild /tmp/arrow-adbc-0.2.0.YfcqT/glib-build/glib > > >>> Failed to verify release candidate. See /tmp/arrow-adbc-0.2.0.YfcqT > for > > >>> details. > > >> > > >> > > >> > > >> > > >> On Fri, Feb 10, 2023 at 10:47 AM David Li <lidav...@apache.org> > wrote: > > >> > > >>> My vote: +1 (binding) > > >>> > > >>> Tested on Ubuntu Linux 18.04/AMD64 and macOS 13.2/AArch64. > > >>> > > >>> On Fri, Feb 10, 2023, at 10:32, David Li wrote: > > >>> > Hmm, you might have to `docker pull debian:bookworm`. > > >>> > > > >>> > On Fri, Feb 10, 2023, at 10:00, Raúl Cumplido wrote: > > >>> >> +1 (non-binding) > > >>> >> > > >>> >> I ran the following on Ubuntu 22.04: > > >>> >> > > >>> >> TEST_APT=0 USE_CONDA=1 dev/release/verify-release-candidate.sh > > 0.2.0 1 > > >>> >> successfully. > > >>> >> > > >>> >> I had to use TEST_APT=0 because I had a small issue on it but that > > >>> >> might be something on my end, sharing the error: > > >>> >> > > >>> >> Running hooks in /etc/ca-certificates/update.d... > > >>> >> done. > > >>> >> ++ lsb_release --codename --short > > >>> >> + code_name=bookworm > > >>> >> ++ lsb_release --id --short > > >>> >> ++ tr A-Z a-z > > >>> >> + distribution=debian > > >>> >> + artifactory_base_url= > > https://apache.jfrog.io/artifactory/arrow/debian > > >>> >> + case "${TYPE}" in > > >>> >> + suffix=rc > > >>> >> + artifactory_base_url+=-rc > > >>> >> + case "${distribution}-${code_name}" in > > >>> >> + sed -i -e 's/ main$/ main contrib non-free/g' > > >>> >> /etc/apt/sources.list.d/debian.sources > > >>> >> sed: can't read /etc/apt/sources.list.d/debian.sources: No such > file > > >>> >> or directory > > >>> >> Failed to verify the APT repository for debian:bookworm > > >>> >> Failed to verify release candidate. See > /tmp/arrow-adbc-0.2.0.sNPBe > > for > > >>> details. > > >>> >> > > >>> >> Thanks, > > >>> >> Raúl > > >>> >> > > >>> >> El vie, 10 feb 2023 a las 7:32, Sutou Kouhei (<k...@clear-code.com > >) > > >>> escribió: > > >>> >>> > > >>> >>> +1 > > >>> >>> > > >>> >>> I ran the following on Debian GNU/Linux sid: > > >>> >>> > > >>> >>> dev/release/verify-release-candidate.sh 0.2.0 1 > > >>> >>> > > >>> >>> with: > > >>> >>> > > >>> >>> * Python 3.10.9 > > >>> >>> * g++ (Debian 12.2.0-14) 12.2.0 > > >>> >>> * openjdk version "17.0.5" 2022-10-18 > > >>> >>> * ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) > > [x86_64-linux-gnu] > > >>> >>> > > >>> >>> > > >>> >>> Thanks, > > >>> >>> -- > > >>> >>> kou > > >>> >>> > > >>> >>> In <cf9bd711-2b96-4bc8-bd19-fee64e2cd...@app.fastmail.com> > > >>> >>> "[VOTE] Release Apache Arrow ADBC 0.2.0 - RC1" on Thu, 09 Feb > > 2023 > > >>> 10:05:24 -0500, > > >>> >>> "David Li" <lidav...@apache.org> wrote: > > >>> >>> > > >>> >>> > Hello, > > >>> >>> > > > >>> >>> > I would like to propose the following release candidate (RC1) > of > > >>> Apache Arrow ADBC version 0.2.0. This is a release consisting of 34 > > >>> resolved GitHub issues [1]. > > >>> >>> > > > >>> >>> > This release candidate is based on commit: > > >>> de79252f70dfc145b853530f328b0c6dfed3085f [2] > > >>> >>> > > > >>> >>> > The source release rc1 is hosted at [3]. > > >>> >>> > The binary artifacts are hosted at [4][5][6][7][8]. > > >>> >>> > The changelog is located at [9]. > > >>> >>> > > > >>> >>> > Please download, verify checksums and signatures, run the unit > > >>> tests, and vote on the release. See [10] for how to validate a > release > > >>> candidate. > > >>> >>> > > > >>> >>> > See also a verification result on GitHub Actions [11]. > > >>> >>> > > > >>> >>> > The vote will be open for at least 72 hours. > > >>> >>> > > > >>> >>> > [ ] +1 Release this as Apache Arrow ADBC 0.2.0 > > >>> >>> > [ ] +0 > > >>> >>> > [ ] -1 Do not release this as Apache Arrow ADBC 0.2.0 > because... > > >>> >>> > > > >>> >>> > Note: to verify APT/YUM packages on macOS/AArch64, you must > > `export > > >>> DOCKER_DEFAULT_ARCHITECTURE=linux/amd64`. (Or skip this step by > `export > > >>> TEST_APT=0 TEST_YUM=0`.) > > >>> >>> > > > >>> >>> > Thanks to Kou for his help with the release. > > >>> >>> > > > >>> >>> > [1]: > > >>> > > > https://github.com/apache/arrow-adbc/issues?q=is%3Aissue+is%3Aclosed+milestone%3A%22ADBC+Libraries+0.2.0%22 > > >>> >>> > [2]: > > >>> > https://github.com/apache/arrow-adbc/tree/apache-arrow-adbc-0.2.0-rc1 > > >>> >>> > [3]: > > >>> > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-adbc-0.2.0-rc1/ > > >>> >>> > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ > > >>> >>> > [5]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ > > >>> >>> > [6]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ > > >>> >>> > [7]: > > >>> > > > https://repository.apache.org/content/repositories/staging/org/apache/arrow/adbc/ > > >>> >>> > [8]: > > >>> > > > https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.2.0-rc1 > > >>> >>> > [9]: > > >>> > > > https://github.com/apache/arrow-adbc/blob/apache-arrow-adbc-0.2.0-rc1/CHANGELOG.md > > >>> >>> > [10]: > > >>> > > > https://arrow.apache.org/adbc/main/development/releasing.html#how-to-verify-release-candidates > > >>> >>> > [11]: > > https://github.com/apache/arrow-adbc/actions/runs/4135206064 > > >>> > > >
