Thanks Raul. Perhaps we could limit the stale bot to PRs that have been in "awaiting changes" for 30 or more days?
On Thu, Mar 30, 2023 at 11:36 AM Raúl Cumplido <raulcumpl...@gmail.com> wrote: > I suppose we could use the new labels for "awaiting review", "awaiting > committer review", "awaiting changes" and "awaiting change review" to know > whether is stale due to the contributor or the reviewer. > > El jue, 30 mar 2023, 20:08, Will Jones <will.jones...@gmail.com> escribió: > > > First, to clarify: we are discussing for the monorepo only, not for Rust > / > > Julia / etc.? This is a big project, so best to be specific which > > subprojects you are addressing. > > > > I am +0.5 on this. 30 days seems like an appropriate window for this > > project. If the PR was stale because the contributor had not updated it, > it > > seems appropriate. But sometimes it's because it hasn't had an update > from > > reviewers for a while, and in that situation it doesn't seem as ideal. > > > > > > > > On Thu, Mar 30, 2023 at 11:01 AM Anja <anja.kef...@gmail.com> wrote: > > > > > Also, perhaps it can be two bots in an escalated process. A "reminder > > ping" > > > bot every X days, and then a stalebot every X+Y days. > > > > > > On Thu, 30 Mar 2023 at 10:54, Anja <anja.kef...@gmail.com> wrote: > > > > > > > When checked this morning, there were 119 PRs that haven't been > updated > > > in > > > > 30 days. The oldest was nearly 3 years old. > > > > > > > > I propose the addition of a bot that will automatically close any PRs > > > that > > > > haven't been updated in 30 days. The closing will act as a > notification > > > to > > > > the reviewers and submitter to evaluate if the work still has value, > > and > > > > just outright close work that is too out-dated for a straightforward > > > merge. > > > > > > > > If the behaviour is done by a bot, it could reduce maintenance > burden, > > > and > > > > simplify the emotional response. A bot can link to a policy, and it > > feels > > > > neutral in its consistent tone. > > > > > > > > > > > > > > > > > >
