Hi,
There has been an issue identified on the Release Candidate on the
source verification on MacOS if the last homebrew version of protobuf
is used [1].
On that case we can specify -DProtobuf_SOURCE=BUNDLED like:
ARROW_CMAKE_OPTIONS="-DProtobuf_SOURCE=BUNDLED"
dev/release/verify-release-candidate.sh ...
All the verification results have been successful on the PR [2] and I
have run the MacOS source verification tasks (also tracked on that PR)
with the following patch to use Bundled protobuf:
diff --git a/dev/release/verify-release-candidate.sh
b/dev/release/verify-release-candidate.sh
index 12e6d9c..9bb39b2 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -602,6 +602,10 @@ test_and_install_cpp() {
ARROW_CMAKE_OPTIONS="${ARROW_CMAKE_OPTIONS:-} -G ${CMAKE_GENERATOR}"
fi
+ if [ "$(uname)" == "Darwin" ]; then
+ brew uninstall --force protobuf abseil grpc
+ fi
+
cmake \
-DARROW_BOOST_USE_SHARED=ON \
-DARROW_BUILD_EXAMPLES=OFF \
@@ -638,6 +642,7 @@ test_and_install_cpp() {
-DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
-DGTest_SOURCE=BUNDLED \
+ -DProtobuf_SOURCE=BUNDLED \
-DPARQUET_BUILD_EXAMPLES=ON \
-DPARQUET_BUILD_EXECUTABLES=ON \
-DPARQUET_REQUIRE_ENCRYPTION=ON \
As discussed on Zulip and the issue, this should not be a blocker for
the release.
Regards,
Raúl
[1] https://github.com/apache/arrow/issues/35987
[2] https://github.com/apache/arrow/pull/35967
El vie, 9 jun 2023 a las 14:32, Raúl Cumplido (<[email protected]>) escribió:
>
> Hi,
>
> I would like to propose the following release candidate (RC1) of Apache
> Arrow version 12.0.1. This is a release consisting of 29
> resolved GitHub issues[1].
>
> This release candidate is based on commit:
> 6af660f48472b8b45a5e01b7136b9b040b185eb1 [2]
>
> The source release rc1 is hosted at [3].
> The binary artifacts are hosted at [4][5][6][7][8][9][10][11].
> The changelog is located at [12].
>
> Please download, verify checksums and signatures, run the unit tests,
> and vote on the release. See [13] for how to validate a release candidate.
>
> See also a verification result on GitHub pull request [14].
>
> The vote will be open for at least 72 hours.
>
> [ ] +1 Release this as Apache Arrow 12.0.1
> [ ] +0
> [ ] -1 Do not release this as Apache Arrow 12.0.1 because...
>
> [1]:
> https://github.com/apache/arrow/issues?q=is%3Aissue+milestone%3A12.0.1+is%3Aclosed
> [2]:
> https://github.com/apache/arrow/tree/6af660f48472b8b45a5e01b7136b9b040b185eb1
> [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-12.0.1-rc1
> [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/
> [5]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/
> [6]: https://apache.jfrog.io/artifactory/arrow/centos-rc/
> [7]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
> [8]: https://apache.jfrog.io/artifactory/arrow/java-rc/12.0.1-rc1
> [9]: https://apache.jfrog.io/artifactory/arrow/nuget-rc/12.0.1-rc1
> [10]: https://apache.jfrog.io/artifactory/arrow/python-rc/12.0.1-rc1
> [11]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
> [12]:
> https://github.com/apache/arrow/blob/6af660f48472b8b45a5e01b7136b9b040b185eb1/CHANGELOG.md
> [13]:
> https://cwiki.apache.org/confluence/display/ARROW/How+to+Verify+Release+Candidates
> [14]: https://github.com/apache/arrow/pull/35967
