Hi, How about breaking down to small sub-tasks? For example, "add support for only list<int32>", "add support for only list<bool>" and so on.
Small sub-PRs are easier to review than one large PR. For example, we're using this approach to support Azure Blob Storage support: The original large PR (couldn't be merged): https://github.com/apache/arrow/pull/12914 Broken down PRs: * https://github.com/apache/arrow/pull/35701 * https://github.com/apache/arrow/pull/36988 * https://github.com/apache/arrow/pull/38269 * ... Thanks, -- kou In <cadcyc901zahy4p3yrj-py4y1yxg0d+joh4+nmehiyecob0s...@mail.gmail.com> "Gandiva List Type feature development" on Fri, 3 Nov 2023 15:46:12 -0700, Logan Riggs <logan.ri...@dremio.com.INVALID> wrote: > Hi, > > I'm working on adding List support to Gandiva and its turning into a fairly > complicated feature. I have code that works for a few list types (ie > list<int32> etc) but I'm not at the stage yet for a formal PR (needs more > tests and some tests are broken, code needs to be cleaned up some). Is > there a general process for getting early feedback on a proposed change? > For example a work in progress PR or design doc review maybe? > > For reference, my change is an expansion/continuation of this abandoned PR: > https://github.com/apache/arrow/pull/9060 > > Thanks > Logan
