It's 9:10pm and I should probably check in with my dev team before tossing this off but I'm trying to give them the longest Thanksgiving break I can.
I'm fairly sure it was this PR: https://github.com/apache/arrow/pull/35656 Long story short, we didn't know it at the time but we were depending on the forced coercion to nanoseconds. On Tue, Nov 21, 2023 at 5:26 PM Bryce Mecum <bryceme...@gmail.com> wrote: > Hi Chris, this is very much the place to ask a question like this and > thanks for doing so. > > Could we get a little more information on the specific change you were > affected by just so we're all on the same page? Was this the bump from > Parquet 2.4 to 2.6 [1] that happened in the PyArrow 13 release [2] or > something else? > > Currently, breaking changes are communicated in the release blog post > [2] and the corresponding GitHub Issue gets a Breaking Change label > [3], as documented in our development guide [4]. When you say > "change-logs", are you referring to the changelogs on our release page > [5]? > > [1] https://github.com/apache/arrow/issues/35746 > [2] https://arrow.apache.org/blog/2023/08/24/13.0.0-release/ > [3] https://github.com/apache/arrow/labels > [4] https://arrow.apache.org/docs/developers/reviewing.html#labelling > [5] https://arrow.apache.org/release/13.0.0.html#changelog > > On Tue, Nov 21, 2023 at 1:00 PM Chris Thomas <ctho...@tracer.tech> wrote: > > > > Evening folks, > > > > I apologize if this is not the appropriate venue for this request; if > > that's the case, please let me know where I should be asking: > > > > Earlier this month Dependabot flagged a security vulnerability with > PyArrow > > which prompted us to do an upgrade from v10 to v14.1 of the software. > > Obviously this is a lot of major versions so the upgrade was subjected > to a > > bunch of tests but, alas, there was a breaking change to the way PyArrow > > handled time precision that slipped through the cracks. > > > > Upon review I'm not sure how that change could possibly have been caught. > > The change-logs for the package are a verbose dump of all of the PRs > > included in the release. Working out which of them constitute a breaking > > change and what the implications are of that change is difficult. > > > > Is this something that could be addressed in the project? > > > > -- > > > > Best, > > > > Chris Thomas > > Engineering Manager - Feature Team > > 540.808.2782 > -- Best, Chris Thomas Engineering Manager - Feature Team 540.808.2782
