+1!
I ran:
export DOCKER_DEFAULT_PLATFORM=linux/amd64
USE_CONDA=1 dev/release/verify-release-candidate.sh 0.11.0 0
Matt - could you open an issue? The R package is not supposed to run
those tests unless some very specific environment variables are
defined in ~/.Renviron.
On Thu, Mar 28, 2024 at 3:27 PM Matt Topol <zotthewiz...@gmail.com> wrote:
>
> +1 (binding)
>
> Verified on PopOS! 22.04 amd64 using Conda with:
>
> USE_CONDA=1 ./dev/release/verify-release-candidate.sh 0.11.0 0
>
> Though there's one issue that i don't think should block the release:
>
> > Running the tests in ‘tests/testthat.R’ failed.
> > Last 13 lines of output:
> > ── Error ('test-adbcsnowflake-package.R:28:3'): default options can open
> a database and execute a query ──
> > <adbc_status_io/adbc_status/simpleError/error/condition>
> > Error in `force(code)`: IO: 390100 (08004): Incorrect username or
> password was specified.
> > Backtrace:
> > ▆
> > 1. ├─adbcdrivermanager::adbc_connection_init(db) at
> test-adbcsnowflake-package.R:28:3
> > 2. └─adbcsnowflake:::adbc_connection_init.adbcsnowflake_database(db)
> > 3. └─adbcdrivermanager::adbc_connection_init_default(...)
> > 4. ├─adbcdrivermanager::with_adbc(...)
> > 5. │ └─base::force(code)
> > 6. └─adbcdrivermanager:::stop_for_error(status, error)
> >
> > [ FAIL 1 | WARN 0 | SKIP 0 | PASS 2 ]
> > Error: Test failures
> > Execution halted
> > * DONE
>
> It looks like the R package needs to skip snowflake tests when the
> username/password aren't provided.
>
> On Thu, Mar 28, 2024 at 12:40 PM Dane Pitkin <d...@voltrondata.com.invalid>
> wrote:
>
> > +1 (non-binding)
> >
> > Verified on MacOS 14.4.1 aarch64 with Conda using:
> >
> > DOCKER_DEFAULT_PLATFORM=linux/amd64 USE_CONDA=1
> > ./dev/release/verify-release-candidate.sh 0.11.0 0
> >
> > On Thu, Mar 28, 2024 at 11:07 AM David Li <lidav...@apache.org> wrote:
> >
> > > Hello,
> > >
> > > I would like to propose the following release candidate (RC0) of Apache
> > > Arrow ADBC version 0.11.0. This is a release consisting of 36 resolved
> > > GitHub issues [1].
> > >
> > > This release candidate is based on commit:
> > > 3cb5825bf551ae93d0e9ed2f64be226b569b27a7 [2]
> > >
> > > The source release rc0 is hosted at [3].
> > > The binary artifacts are hosted at [4][5][6][7][8].
> > > The changelog is located at [9].
> > >
> > > Please download, verify checksums and signatures, run the unit tests, and
> > > vote on the release. See [10] for how to validate a release candidate.
> > >
> > > See also a verification result on GitHub Actions [11].
> > >
> > > The vote will be open for at least 72 hours.
> > >
> > > [ ] +1 Release this as Apache Arrow ADBC 0.11.0
> > > [ ] +0
> > > [ ] -1 Do not release this as Apache Arrow ADBC 0.11.0 because...
> > >
> > > Note: to verify APT/YUM packages on macOS/AArch64, you must `export
> > > DOCKER_DEFAULT_PLATFORM=linux/amd64`. (Or skip this step by `export
> > > TEST_APT=0 TEST_YUM=0`.)
> > >
> > > [1]:
> > >
> > https://github.com/apache/arrow-adbc/issues?q=is%3Aissue+milestone%3A%22ADBC+Libraries+0.11.0%22+is%3Aclosed
> > > [2]:
> > >
> > https://github.com/apache/arrow-adbc/commit/3cb5825bf551ae93d0e9ed2f64be226b569b27a7
> > > [3]:
> > >
> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-adbc-0.11.0-rc0/
> > > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/
> > > [5]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
> > > [6]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
> > > [7]:
> > >
> > https://repository.apache.org/content/repositories/staging/org/apache/arrow/adbc/
> > > [8]:
> > >
> > https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-0.11.0-rc0
> > > [9]:
> > >
> > https://github.com/apache/arrow-adbc/blob/apache-arrow-adbc-0.11.0-rc0/CHANGELOG.md
> > > [10]:
> > >
> > https://arrow.apache.org/adbc/main/development/releasing.html#how-to-verify-release-candidates
> > > [11]: https://github.com/apache/arrow-adbc/actions/runs/8468352632
> > >
> >
