+1 (binding)

Verified on M3 after setting RUST_MIN_STACK=3000000.

Thanks Andy.

On Thu, Mar 28, 2024 at 7:39 PM Andy Grove <andygrov...@gmail.com> wrote:
>
> Yes, I also saw this (both on Ubuntu and Mac), and I had to set
> RUST_MIN_STACK=3000000 for the tests to pass.
>
> I filed https://github.com/apache/arrow-datafusion/issues/9848 to improve
> the release verification documentation to mention this.
>
>
> On Thu, Mar 28, 2024 at 7:59 PM L. C. Hsieh <vii...@gmail.com> wrote:
>
> > I got the following error when running verify-release-candidate.sh:
> >
> > thread 'tpcds_physical_q54' has overflowed its stack
> > fatal runtime error: stack overflow
> > error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
> >
> >
> > On Thu, Mar 28, 2024 at 4:22 PM Andy Grove <andygrov...@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > I would like to propose a release of Apache Arrow DataFusion
> > Implementation,
> > > version 37.0.0.
> > >
> > > This release candidate is based on commit:
> > > 799be5e76bd631608b2357dbbe600afc2cebc359 [1]
> > > The proposed release tarball and signatures are hosted at [2].
> > > The changelog is located at [3].
> > >
> > > Please download, verify checksums and signatures, run the unit tests, and
> > > vote
> > > on the release. The vote will be open for at least 72 hours.
> > >
> > > Only votes from PMC members are binding, but all members of the community
> > > are
> > > encouraged to test the release and vote with "(non-binding)".
> > >
> > > The standard verification procedure is documented at
> > >
> > https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
> > > .
> > >
> > > [ ] +1 Release this as Apache Arrow DataFusion 37.0.0
> > > [ ] +0
> > > [ ] -1 Do not release this as Apache Arrow DataFusion 37.0.0 because...
> > >
> > > Here is my vote:
> > >
> > > +1
> > >
> > > *NOTE: I had to set RUST_MIN_STACK=3000000 for the tests to pass.*
> > >
> > > [1]:
> > >
> > https://github.com/apache/arrow-datafusion/tree/799be5e76bd631608b2357dbbe600afc2cebc359
> > > [2]:
> > >
> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.0.0-rc1
> > > [3]:
> > >
> > https://github.com/apache/arrow-datafusion/blob/799be5e76bd631608b2357dbbe600afc2cebc359/CHANGELOG.md
> >

Reply via email to