+1 (non-binding)

Verified on MacOS 14 aarch64 with:

DOCKER_DEFAULT_PLATFORM=linux/amd64 USE_CONDA=1
./dev/release/verify-release-candidate.sh 13 0

I also had to install arrow-glib-devel in ./dev/release/verify-yum.sh to
fully verify the release:

+${install_command} --enablerepo=epel arrow-glib-devel
 ${install_command} --enablerepo=epel adbc
-arrow-glib-devel-${package_version}
 ${install_command} --enablerepo=epel adbc-arrow-glib-doc-${package_version}


On Mon, Jul 1, 2024 at 8:49 PM Matt Topol <zotthewiz...@gmail.com> wrote:

> +1 (binding)
>
> Release candidate validated successfully with:
> USE_CONDA=0 dev/release/verify-release-candidate.sh 13 0
>
> using Pop_OS! 22.04
>
> Same issue as Kou, i needed to install arrow-glib-devel manually to get
> verification to work
>
> On Mon, Jul 1, 2024 at 8:31 PM Sutou Kouhei <k...@clear-code.com> wrote:
>
> > +1 (binding)
> >
> > I ran the following on Debian GNU/Linux sid:
> >
> >   TEST_DEFAULT=0 \
> >     TEST_SOURCE=1 \
> >     LANG=C \
> >     TZ=UTC \
> >     JAVA_HOME=/usr/lib/jvm/default-java \
> >     dev/release/verify-release-candidate.sh 13 0
> >
> >   TEST_DEFAULT=0 \
> >     TEST_APT=1 \
> >     LANG=C \
> >     dev/release/verify-release-candidate.sh 13 0
> >
> >   TEST_DEFAULT=0 \
> >     TEST_BINARY=1 \
> >     LANG=C \
> >     dev/release/verify-release-candidate.sh 13 0
> >
> >   TEST_DEFAULT=0 \
> >     TEST_JARS=1 \
> >     LANG=C \
> >     dev/release/verify-release-candidate.sh 13 0
> >
> >   TEST_DEFAULT=0 \
> >     TEST_WHEELS=1 \
> >     TEST_PYTHON_VERSIONS=3.11 \
> >     LANG=C \
> >     TZ=UTC \
> >     dev/release/verify-release-candidate.sh 13 0
> >
> >   TEST_DEFAULT=0 \
> >     TEST_YUM=1 \
> >     LANG=C \
> >     dev/release/verify-release-candidate.sh 13 0
> >
> > with:
> >
> >   * g++ (Debian 13.3.0-1) 13.3.0
> >   * go version go1.22.4 linux/amd64
> >   * openjdk version "17.0.11" 2024-04-16
> >   * Python 3.11.9
> >   * ruby 3.1.2p20 (2022-04-12 revision 4491bb740a) [x86_64-linux-gnu]
> >   * R version 4.4.1 (2024-06-14) -- "Race for Your Life"
> >   * Apache Arrow 17.0.0-SNAPSHOT
> >
> > Note:
> >
> > I needed to install arrow-glib-devel explicitly to verify
> > Yum repository like I did for ADBC 12:
> >
> > ----
> > diff --git a/dev/release/verify-yum.sh b/dev/release/verify-yum.sh
> > index f7f023611..ff30176f1 100755
> > --- a/dev/release/verify-yum.sh
> > +++ b/dev/release/verify-yum.sh
> > @@ -170,6 +170,7 @@ echo "::endgroup::"
> >
> >  echo "::group::Test ADBC Arrow GLib"
> >
> > +${install_command} --enablerepo=epel arrow-glib-devel
> >  ${install_command} --enablerepo=epel
> > adbc-arrow-glib-devel-${package_version}
> >  ${install_command} --enablerepo=epel
> > adbc-arrow-glib-doc-${package_version}
> >
> > ----
> >
> > This is not a blocker for 13 too. I want to find the
> > solution for this but I don' have any idea yet...
> >
> >
> > Thanks,
> > --
> > kou
> >
> > In <aa550ebe-8097-4a36-9f4f-0106b6f5b...@app.fastmail.com>
> >   "[VOTE] Release Apache Arrow ADBC 13 - RC0" on Mon, 01 Jul 2024
> 17:01:02
> > +0900,
> >   "David Li" <lidav...@apache.org> wrote:
> >
> > > Hello,
> > >
> > > I would like to propose the following release candidate (RC0) of Apache
> > Arrow ADBC version 13. This is a release consisting of 24 resolved GitHub
> > issues [1].
> > >
> > > The subcomponents are versioned independently:
> > >
> > > - C/C++/GLib/Go/Python/Ruby: 1.1.0
> > > - C#: 0.13.0
> > > - Java: 0.13.0
> > > - R: 0.13.0
> > > - Rust: 0.13.0
> > >
> > > This release candidate is based on commit:
> > 37f79efbcd1641e6906a36e76df57cb896f2bc68 [2]
> > >
> > > The source release rc0 is hosted at [3].
> > > The binary artifacts are hosted at [4][5][6][7][8].
> > > The changelog is located at [9].
> > >
> > > Please download, verify checksums and signatures, run the unit tests,
> > and vote on the release. See [10] for how to validate a release
> candidate.
> > >
> > > See also a verification result on GitHub Actions [11].
> > >
> > > The vote will be open for at least 72 hours.
> > >
> > > [ ] +1 Release this as Apache Arrow ADBC 13
> > > [ ] +0
> > > [ ] -1 Do not release this as Apache Arrow ADBC 13 because...
> > >
> > > Note: to verify APT/YUM packages on macOS/AArch64, you must `export
> > DOCKER_DEFAULT_PLATFORM=linux/amd64`. (Or skip this step by `export
> > TEST_APT=0 TEST_YUM=0`.)
> > >
> > > [1]:
> >
> https://github.com/apache/arrow-adbc/issues?q=is%3Aissue+milestone%3A%22ADBC+Libraries+13%22+is%3Aclosed
> > > [2]:
> >
> https://github.com/apache/arrow-adbc/commit/37f79efbcd1641e6906a36e76df57cb896f2bc68
> > > [3]:
> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-adbc-13-rc0/
> > > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/
> > > [5]: https://apache.jfrog.io/artifactory/arrow/debian-rc/
> > > [6]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/
> > > [7]:
> >
> https://repository.apache.org/content/repositories/staging/org/apache/arrow/adbc/
> > > [8]:
> >
> https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-13-rc0
> > > [9]:
> >
> https://github.com/apache/arrow-adbc/blob/apache-arrow-adbc-13-rc0/CHANGELOG.md
> > > [10]:
> >
> https://arrow.apache.org/adbc/main/development/releasing.html#how-to-verify-release-candidates
> > > [11]: https://github.com/apache/arrow-adbc/actions/runs/9739916017
> >
>

Reply via email to