Adam, Yes, I saw that when it was introduced here, on a PR I did: https://github.com/apache/arrow/runs/25894658283
It's on the smallest scale factor and on two of the queries ( https://github.com/voltrondata-labs/arrowbench/blob/main/R/tpch-queries.R#L510-L535 and https://github.com/voltrondata-labs/arrowbench/blob/main/R/tpch-queries.R#L583-L599). I looked into it, and after digging into the limited output available from conbench, I wasn't convinced that it was meaningful. My theory based on the changes I made is that the queries themselves aren't actually running in Acero, that for some reason they're failing to translate into arrow expressions and are falling back to running in regular dplyr in R. I made a change in that PR that would make that fallback code path slower in some circumstances. So the benchmarks may have regressed, but they aren't really testing Arrow code--at least that's my theory. Of course, "no regression" would be preferable. I didn't (and don't now) have time to dig further into it, but others are welcome to if they can. Neal On Mon, Jul 15, 2024 at 9:07 AM Adam Lippai <a...@rigo.sk> wrote: > Do I read it correctly that there is tpch regression in the R benchmark? > > Best regards, > Adam Lippai > > On Mon, Jul 15, 2024 at 06:05 Fokko Driesprong <fo...@apache.org> wrote: > > > Thanks to everyone who contributed to the new release! > > > > +1 (non-binding) > > > > I've tested against PyIceberg > > <https://github.com/apache/iceberg-python/pull/929>. > > > > Kind regards, > > Fokko > > > > Op ma 15 jul 2024 om 10:29 schreef David Li <lidav...@apache.org>: > > > > > +1 (binding) > > > > > > Tested on Debian 12/x86_64 > > > > > > On Mon, Jul 15, 2024, at 15:31, Gang Wu wrote: > > > > +1 (non-binding) > > > > > > > > Verified C++ on my M1 Mac by running: > > > > - TEST_DEFAULT=0 TEST_CPP=1 ./verify-release-candidate.sh 17.0.0 2 > > > > > > > > BTW, I ran into this issue as well: > > > > https://github.com/apache/arrow/issues/43167 > > > > > > > > Best, > > > > Gang > > > > > > > > On Mon, Jul 15, 2024 at 1:39 PM Jean-Baptiste Onofré < > j...@nanthrax.net> > > > > wrote: > > > > > > > >> +1 (non binding) > > > >> > > > >> Regards > > > >> JB > > > >> > > > >> On Fri, Jul 12, 2024 at 11:56 AM Raúl Cumplido <rau...@apache.org> > > > wrote: > > > >> > > > > >> > Hi, > > > >> > > > > >> > I would like to propose the following release candidate (RC2) of > > > Apache > > > >> > Arrow version 17.0.0. This is a release consisting of 321 > > > >> > resolved GitHub issues[1]. > > > >> > > > > >> > This release candidate is based on commit: > > > >> > 6a2e19a852b367c72d7b12da4d104456491ed8b7 [2] > > > >> > > > > >> > The source release rc2 is hosted at [3]. > > > >> > The binary artifacts are hosted at [4][5][6][7][8][9][10][11]. > > > >> > The changelog is located at [12]. > > > >> > > > > >> > Please download, verify checksums and signatures, run the unit > > tests, > > > >> > and vote on the release. See [13] for how to validate a release > > > >> candidate. > > > >> > > > > >> > See also a verification result on GitHub pull request [14]. > > > >> > > > > >> > The vote will be open for at least 72 hours. > > > >> > > > > >> > [ ] +1 Release this as Apache Arrow 17.0.0 > > > >> > [ ] +0 > > > >> > [ ] -1 Do not release this as Apache Arrow 17.0.0 because... > > > >> > > > > >> > [1]: > > > >> > > > > > > https://github.com/apache/arrow/issues?q=is%3Aissue+milestone%3A17.0.0+is%3Aclosed > > > >> > [2]: > > > >> > > > > > > https://github.com/apache/arrow/tree/6a2e19a852b367c72d7b12da4d104456491ed8b7 > > > >> > [3]: > > > >> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-17.0.0-rc2 > > > >> > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ > > > >> > [5]: https://apache.jfrog.io/artifactory/arrow/amazon-linux-rc/ > > > >> > [6]: https://apache.jfrog.io/artifactory/arrow/centos-rc/ > > > >> > [7]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ > > > >> > [8]: https://apache.jfrog.io/artifactory/arrow/java-rc/17.0.0-rc2 > > > >> > [9]: > https://apache.jfrog.io/artifactory/arrow/nuget-rc/17.0.0-rc2 > > > >> > [10]: > > https://apache.jfrog.io/artifactory/arrow/python-rc/17.0.0-rc2 > > > >> > [11]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ > > > >> > [12]: > > > >> > > > > > > https://github.com/apache/arrow/blob/6a2e19a852b367c72d7b12da4d104456491ed8b7/CHANGELOG.md > > > >> > [13]: > > > https://arrow.apache.org/docs/developers/release_verification.html > > > >> > [14]: https://github.com/apache/arrow/pull/43220 > > > >> > > > > > >
