+1 (non binding) - hash and checksum are good - LICENSE is good, even if I would separate the pure LICENSE for the source distribution (code copy) from the LICENSE for binary distribution (about statically linked deps) - NOTICE for source distribution looks good, but it's not valid for binary distribution. For instance, binary distribution NOTICE should contain the notice from AWS SDK2 Go. I will propose a PR about LICENSE/NOTICE improvements. - A few binary files in the source distribution but acceptable (svg, drawio, ...) - Some files don't have ASF header (some are "normal", some look a bit weird to me) - Build and run on Ubuntu without problem
Thanks Regards JB On Mon, Mar 3, 2025 at 5:54 AM David Li <lidav...@apache.org> wrote: > > Hello, > > I would like to propose the following release candidate (RC0) of Apache Arrow > ADBC version 17. This is a release consisting of 18 resolved GitHub issues > [1]. > > The subcomponents are versioned independently: > > - C/C++/GLib/Go/Python/Ruby: 1.5.0 > - C#: 0.17.0 > - Java: 0.17.0 > - R: 0.17.0 > - Rust: 0.17.0 > > This release candidate is based on commit: > 8b4ba558d1e9db9afbea6ef2d50acd979f647799 [2] > > The source release rc0 is hosted at [3]. > The binary artifacts are hosted at [4][5][6][7][8]. > The changelog is located at [9]. > > Please download, verify checksums and signatures, run the unit tests, and > vote on the release. See [10] for how to validate a release candidate. > > See also a verification result on GitHub Actions [11]. > > The vote will be open for at least 72 hours. > > [ ] +1 Release this as Apache Arrow ADBC 17 > [ ] +0 > [ ] -1 Do not release this as Apache Arrow ADBC 17 because... > > Note: to verify APT/YUM packages on macOS/AArch64, you must `export > DOCKER_DEFAULT_PLATFORM=linux/amd64`. (Or skip this step by `export > TEST_APT=0 TEST_YUM=0`.) > > [1]: > https://github.com/apache/arrow-adbc/issues?q=is%3Aissue+milestone%3A%22ADBC+Libraries+17%22+is%3Aclosed > [2]: > https://github.com/apache/arrow-adbc/commit/8b4ba558d1e9db9afbea6ef2d50acd979f647799 > [3]: https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-adbc-17-rc0/ > [4]: https://apache.jfrog.io/artifactory/arrow/almalinux-rc/ > [5]: https://apache.jfrog.io/artifactory/arrow/debian-rc/ > [6]: https://apache.jfrog.io/artifactory/arrow/ubuntu-rc/ > [7]: > https://repository.apache.org/content/repositories/staging/org/apache/arrow/adbc/ > [8]: > https://github.com/apache/arrow-adbc/releases/tag/apache-arrow-adbc-17-rc0 > [9]: > https://github.com/apache/arrow-adbc/blob/apache-arrow-adbc-17-rc0/CHANGELOG.md#adbc-libraries-17-2025-03-03 > [10]: > https://arrow.apache.org/adbc/main/development/releasing.html#how-to-verify-release-candidates > [11]: https://github.com/apache/arrow-adbc/actions/runs/13623031815
