+1 (non-binding)

I verified:
- GPG signature against both the dev and release KEYS
- SHA256 and SHA512 checksums
- The source tarball matches tag 57.3.3-rc1 (commit 
a10c413c0867381071c7f7c6d11cde7a283448e3), apart from the generated 
.gitmodules-commits
- RAT license header check
- No unexpected binaries in the source tarball
- cargo build and cargo test --workspace pass on Linux x86_64 (Rust 1.91.1)

A non-blocking follow-up: arrow-array/src/delta.rs is copied from the 
chronoutil crate under MIT. The file keeps its MIT notice, but the top-level 
LICENSE.txt doesn't mention it. It would be good to list it there in a future 
release, and to update the year range in NOTICE.txt (still 2016-2019).

Some files say they are based on outside sources whose licenses aren't in the 
top-level LICENSE: a Serde documentation example 
(arrow-json/src/reader/serializer.rs), a Hadoop LZ4 routine adapted from 
Polars/parquet2 (parquet/src/compression.rs), and a varint routine citing 
Google protobuf and protobuf-go (arrow-avro/src/reader/vlq.rs). It might be 
worth confirming where these came from and adding LICENSE entries where needed. 
I don't consider any of this blocking.

Thanks for managing the release!

Xuanwo

Reply via email to