+1 (non-binding)
I verified:
[x] Signature valid (key 9656D04925F17EEA93F3E0D0B54DF4E301027EAE, present in
both dev and release KEYS)
[x] SHA-256 and SHA-512 checksums match, and the SHA-256 matches the one in
this email
[x] Source tarball matches commit 076c16208e652aee2b3b698e3491fc1ef2b328c0 /
tag 58.4.2-rc1
(only the generated .gitmodules-commits is added)
[x] No compiled binaries; dev/release/run-rat.sh passes
[x] cargo fmt --check, cargo build --workspace --locked and cargo test
--workspace --locked
pass on Rust 1.91 (6,141 passed, 0 failed)
Two small notes for a follow-up, not blocking this release:
1. arrow-array/src/delta.rs includes MIT-licensed code from chronoutil. The MIT
text is in
arrow-array/LICENSE-MIT and NOTICE mentions it, but the top-level
LICENSE.txt doesn't describe
or point to it, as
https://www.apache.org/legal/release-policy.html#distributing-code-under-several-licenses
asks. This is the same as in 58.4.1.
2. dev/release/run-rat.sh calls `python`; on a system with only `python3` it
prints
"python: command not found" but still reports "No unapproved licenses" and
exits 0.
Xuanwo
