>> But in this case it seemed like the test was unnecessary, although I do have tests on my BAD branch that require this change.
It seems useful to me as it will protect the system against future changes. Could you submit a separate new change which only has a test case? Thanks a lot! Best, Yingyi On Wed, Aug 17, 2016 at 6:19 PM, Steven Jacobs <sjaco...@ucr.edu> wrote: > I already pushed the change :( > But in this case it seemed like the test was unnecessary, although I do > have tests on my BAD branch that require this change. > Steven > > On Wed, Aug 17, 2016 at 6:15 PM, Yingyi Bu <buyin...@gmail.com> wrote: > >> Steven, >> >> Can you add a regression test before you closing that issue? >> (Typically, fixing ASTERIXDB-xxxx should have a test case in the >> change.) >> Thanks! >> >> Best, >> Yingyi >> >> On Wed, Aug 17, 2016 at 6:05 PM, ASF subversion and git services (JIRA) < >> j...@apache.org> wrote: >> >>> >>> [ https://issues.apache.org/jira/browse/ASTERIXDB-1587?page=co >>> m.atlassian.jira.plugin.system.issuetabpanels:comment-tabpan >>> el&focusedCommentId=15425696#comment-15425696 ] >>> >>> ASF subversion and git services commented on ASTERIXDB-1587: >>> ------------------------------------------------------------ >>> >>> Commit ddc760f59b906e3124a5da7d73fa7d3575fd79b1 in asterixdb's branch >>> refs/heads/master from [~sjaco002] >>> [ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=ddc760f ] >>> >>> ASTERIXDB-1587 Made upsert look in the correct dataverse for datatypes >>> >>> Change-Id: Iccf04c2210a1535cd7de6eeea88dfefec9ba206a >>> Reviewed-on: https://asterix-gerrit.ics.uci.edu/1085 >>> Reviewed-by: Preston Carman <prest...@apache.org> >>> Sonar-Qube: Jenkins <jenk...@fulliautomatix.ics.uci.edu> >>> Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu> >>> >>> >>> > upsert runtime assumes that the datatype comes from the same dataverse >>> as the dataset >>> > ------------------------------------------------------------ >>> ------------------------- >>> > >>> > Key: ASTERIXDB-1587 >>> > URL: https://issues.apache.org/jira >>> /browse/ASTERIXDB-1587 >>> > Project: Apache AsterixDB >>> > Issue Type: Bug >>> > Reporter: Steven Jacobs >>> > Assignee: Steven Jacobs >>> > >>> > It throws an error if they aren't from the same dataverse. It should >>> work instead. >>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.3.4#6332) >>> >> >> >
