@Taewoo: If you add the bad codebase to your local asterix instance it will be built alongside local builds. You can do this by cloning the bad repository into an asterix-opt folder in Asterix (at the same level as asterix-app). this will cause it to automatically become part of your builds. I think not everyone will want to go through this trouble though :) Steven
On Thu, Dec 15, 2016 at 10:11 AM, Taewoo Kim <[email protected]> wrote: > @Steven: can we check this locally before uploading a patch set? > > Best, > Taewoo > > On Thu, Dec 15, 2016 at 9:37 AM, Ian Maxon <[email protected]> wrote: > > > As a sidenote, it doesn't block, the flag acts the same as SonarQube. If > it > > does break though, please do add a BAD fellow to the review so there's > > visibility as to what broke and when. > > > > On Thu, Dec 15, 2016 at 9:32 AM, Steven Jacobs <[email protected]> wrote: > > > > > Hi all, > > > Those of you with reviews going on may have noticed that there is a new > > > column on gerrit, called bad. This flag is because we now have an > apache > > > codebase for the BAD extension (You can see it here if you are > > interested: > > > https://git-wip-us.apache.org/repos/asf/asterixdb-bad.git) which > enables > > > channels and soon stored procedures. > > > > > > The BAD extension is dependent on the core of Asterix itself. The new > > flag > > > is to check whether new changes to Asterix will break the BAD > extension. > > In > > > general most changes should be getting a +1 here. The main thing we are > > > trying to avoid is a change to Asterix intended as an enhancement or > > > cleanup that inadvertently removes functionality needed for Asterix > > > extensions. > > > > > > "What should I do if I see a -1?" > > > > > > If you do happen to get a -1 from BAD, the easy thing to do is to add > me > > > (or another extension expert such as Till or Abdullah) to the code > > review. > > > That way I can look at the affecting part of the change and see how to > > > handle it. > > > > > > Please let me know if you have any questions or concerns. > > > Thanks, > > > Steven > > > > > >
