Finally, two things have changed in the code style format. You can download new code file.
- Do not remove blank lines in the java-doc comment section. - Wrap an assignment statement when necessary (currently, it doesn't). https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting Best, Taewoo On Tue, Oct 25, 2016 at 4:34 PM, Yingyi Bu <[email protected]> wrote: > >> @Yingyi: I wonder whether your proposed change (do not remove blank > lines > >> in the comment section) is already applied to the format file > > It looks that I haven't... > You can update this row: > > <setting id= > "org.eclipse.jdt.core.formatter.comment.clear_blank_ > lines_in_javadoc_comment" > value="false"/> > > Thanks! > > Yingyi > > > On Tue, Oct 25, 2016 at 4:26 PM, Till Westmann <[email protected]> wrote: > > > +1 > > > > > > On 25 Oct 2016, at 13:29, Taewoo Kim wrote: > > > > There is a formatter issue regarding an assignment statement whose length > >> is over 120. An example is as follows: > >> private final IBinaryComparator strLowerCaseTokenCmp = > >> AqlBinaryComparatorFactoryProvider.UTF8STRING_LOWERCASE_TOKE > >> N_POINTABLE_INSTANCE.createBinaryComparator(); > >> > >> Currently, the formatter doesn't wrap this line into two lines because > "No > >> Wrap" policy is applied. So, I would like to propose the following > change. > >> After applying this change, we can keep the hard limit (120) well. > >> > >> AsterixCodeFormatProfile.xml > >> > >> Line Wrapping -> Expressions -> Assignments > >> > >> (Before) Line Wrapping Policy: Do not Wrap > >> (After) Wrap where necessary > >> > >> @Yingyi: I wonder whether your proposed change (do not remove blank > lines > >> in the comment section) is already applied to the format file. Please > let > >> me know. Then, I will download the file from > >> https://cwiki.apache.org/confluence/download/attachments/ > >> 61322291/AsterixCodeFormatProfile.xml > >> and apply my change and upload the file. > >> > > >
