That clearly works. Or why don't we add reviewers only if the self-review is done? :-)
Best, Taewoo On Fri, Jun 7, 2019 at 12:51 AM Mike Carey <dtab...@gmail.com> wrote: > +1 ! > > On 6/6/19 6:07 PM, Till Westmann wrote: > > Hi, > > > > I've proposed an addition to our code review steps on > > https://cwiki.apache.org/confluence/display/ASTERIXDB/Code+Reviews > > > > The only change from the steps we've been doing so far is the use of a > > "+1" code review by the author of a change to indicate that the > > self-review is done (avoiding the guessing game if a change is > > awaiting review). > > > > Please let me know what you think about this approach. > > > > Cheers, > > Till >
