Yingyi Bu has posted comments on this change.

Change subject: allow btree search to read unregistered indexes.
......................................................................


Patch Set 1:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/324/1/hyracks/hyracks-dataflow-std/src/main/java/edu/uci/ics/hyracks/dataflow/std/file/FileSplit.java
File 
hyracks/hyracks-dataflow-std/src/main/java/edu/uci/ics/hyracks/dataflow/std/file/FileSplit.java:

Line 32:         this.ioDeviceId = 0;
> Just curiously, does ioDeviceId = 0 mean the default location of this file 
Yes.  The parent directory of an index file is:
file.path+"device_id_"+ioDeviceId.
In the directory usually there could be multiple index files, one for each disk 
component, as well as multiple bloom filter files, one for each disk component.


https://asterix-gerrit.ics.uci.edu/#/c/324/1/hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java
File 
hyracks/hyracks-storage-am-common/src/main/java/edu/uci/ics/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java:

Line 121:         synchronized (lcManager) {
> Can it also destroy the index that not created by itself? Do we view the ex
Yes, the can be destroyed here.
We can bulkload external index as well.
For example, a pregelix job can deposit its results to AsterixDB.


https://asterix-gerrit.ics.uci.edu/#/c/324/1/hyracks/hyracks-storage-common/src/main/java/edu/uci/ics/hyracks/storage/common/file/TransientLocalResourceFactoryProvider.java
File 
hyracks/hyracks-storage-common/src/main/java/edu/uci/ics/hyracks/storage/common/file/TransientLocalResourceFactoryProvider.java:

Line 20:     public static TransientLocalResourceFactoryProvider INSTANCE = new 
TransientLocalResourceFactoryProvider();
> Just curious to understand our system, can we have two node Hyracks node on
Nodes only share a single VM in tests.
That is fine for this provider class, because below, each time the 
getLocalResourceFactory() is called, a new resource factory is returned.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/324
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7cc7752dd7b6d5261ff02d591f25d76d442a1c
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Jianfeng Jia <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to