Pouria Pirzadeh has submitted this change and it was merged. Change subject: NKC fix for int64 ......................................................................
NKC fix for int64 Change-Id: I60b3ec3f15921093b1fa11ac9fc157b7930f4e4d Reviewed-on: https://asterix-gerrit.ics.uci.edu/329 Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Reviewed-by: Ian Maxon <ima...@apache.org> Reviewed-by: Yingyi Bu <buyin...@gmail.com> --- M hyracks/hyracks-dataflow-common/src/main/java/edu/uci/ics/hyracks/dataflow/common/data/normalizers/Integer64NormalizedKeyComputerFactory.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yingyi Bu: Looks good to me, approved Ian Maxon: Looks good to me, but someone else must approve Jenkins: Verified diff --git a/hyracks/hyracks-dataflow-common/src/main/java/edu/uci/ics/hyracks/dataflow/common/data/normalizers/Integer64NormalizedKeyComputerFactory.java b/hyracks/hyracks-dataflow-common/src/main/java/edu/uci/ics/hyracks/dataflow/common/data/normalizers/Integer64NormalizedKeyComputerFactory.java index bcff79f..1608327 100644 --- a/hyracks/hyracks-dataflow-common/src/main/java/edu/uci/ics/hyracks/dataflow/common/data/normalizers/Integer64NormalizedKeyComputerFactory.java +++ b/hyracks/hyracks-dataflow-common/src/main/java/edu/uci/ics/hyracks/dataflow/common/data/normalizers/Integer64NormalizedKeyComputerFactory.java @@ -34,7 +34,7 @@ public int normalize(byte[] bytes, int start, int length) { long value = LongPointable.getLong(bytes, start); int highValue = (int) (value >> 32); - if (highValue > 0) { + if (value > Integer.MAX_VALUE) { /** * larger than Integer.MAX */ @@ -42,7 +42,7 @@ highNmk >>= 2; highNmk |= POSTIVE_LONG_MASK; return highNmk; - } else if (highValue == 0) { + } else if (value >=0 && value <= Integer.MAX_VALUE) { /** * smaller than Integer.MAX but >=0 */ -- To view, visit https://asterix-gerrit.ics.uci.edu/329 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60b3ec3f15921093b1fa11ac9fc157b7930f4e4d Gerrit-PatchSet: 4 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Pouria Pirzadeh <pouria.pirza...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Pouria Pirzadeh <pouria.pirza...@gmail.com> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Yingyi Bu <ying...@google.com>
