Can someone give a high level hint about what the 2 or 3x is x'ing? On Aug 9, 2015 11:38 AM, "Yingyi Bu (Code Review)" < [email protected]> wrote:
> Yingyi Bu has posted comments on this change. > > Change subject: This change includes: 1. avoid calling ByteBuffer.get() > and ByteBuffer.put() for bloom filter set/get operations. ByteBuffer will > check boundaries of the index for get/put. It's a very frequent operation. > 2. let the hash table size in BufferCache be 3X of > ...................................................................... > > > Patch Set 1: > > I don't have a strong opinion for the 3X thing. You guys decide... > > -- > To view, visit https://asterix-gerrit.ics.uci.edu/345 > To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: Ifd47c410338ce557a494ab3605660bad1899e786 > Gerrit-PatchSet: 1 > Gerrit-Project: hyracks > Gerrit-Branch: master > Gerrit-Owner: Yingyi Bu <[email protected]> > Gerrit-Reviewer: Ian Maxon <[email protected]> > Gerrit-Reviewer: Jenkins <[email protected]> > Gerrit-Reviewer: Yingyi Bu <[email protected]> > Gerrit-Reviewer: Young-Seok Kim <[email protected]> > Gerrit-HasComments: No >
