Steven Jacobs has posted comments on this change. Change subject: Periodically saving JSON data from admin console API to a temporary dataset. ......................................................................
Patch Set 7: (3 comments) Just a couple of things. Also, I don't know if you knew already but you need to have 2 reviewers to get a +2. https://asterix-gerrit.ics.uci.edu/#/c/350/7/asterix-app/src/main/java/edu/uci/ics/asterix/hyracks/bootstrap/AsterixGlobalRecoveryManager.java File asterix-app/src/main/java/edu/uci/ics/asterix/hyracks/bootstrap/AsterixGlobalRecoveryManager.java: Line 58: // (new Thread(gatherJSONData)).start(); Do we need to keep these comments? https://asterix-gerrit.ics.uci.edu/#/c/350/7/asterix-app/src/main/java/edu/uci/ics/asterix/hyracks/bootstrap/JobLifeCycleListener.java File asterix-app/src/main/java/edu/uci/ics/asterix/hyracks/bootstrap/JobLifeCycleListener.java: Line 45: } Why is everything commented out? https://asterix-gerrit.ics.uci.edu/#/c/350/7/asterix-installer/src/test/resources/integrationts/library/results/library-metadata/dataverseDataset/dataverseDataset.1.adm File asterix-installer/src/test/resources/integrationts/library/results/library-metadata/dataverseDataset/dataverseDataset.1.adm: Line 3: , { "DataverseName": "externallibtest", "DataFormat": "edu.uci.ics.asterix.runtime.formats.NonTaggedDataFormat", "Timestamp": "Thu Apr 25 11:18:12 PDT 2013", "PendingOp": 0 } Maybe give the dataset a name so that people know it is for the web job tracker -- To view, visit https://asterix-gerrit.ics.uci.edu/350 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cb186abda6a14d9eb866259d459ce5b5e855be8 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Pritom Ahmed <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-HasComments: Yes
