Heri Ramampiaro has posted comments on this change. Change subject: Merging with the current master (+ Correcting RecordBuilder instatiation in RecordAddFieldsDescriptor) ......................................................................
Patch Set 9: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/298/9/asterix-om/src/main/java/edu/uci/ics/asterix/om/functions/AsterixBuiltinFunctions.java File asterix-om/src/main/java/edu/uci/ics/asterix/om/functions/AsterixBuiltinFunctions.java: Line 1005: addFunction(CURRENT_TIME, ATimeTypeComputer.INSTANCE, false); > why did these go false? I actually do not know. They appear to have the same values as in the current master version. In any cases, I did not change them. If they are supposed to be 'true', I can surely change them... https://asterix-gerrit.ics.uci.edu/#/c/298/9/asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/functions/records/RecordAddFieldsDescriptor.java File asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/functions/records/RecordAddFieldsDescriptor.java: Line 124: recordBuilder = new RecordBuilder(); > We are creating a new record builder for every tuple? Thank you pointing this out. I was just not careful. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3621ebdd71c7cd91b50d77a972ad863cea7fcbc2 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
