Taewoo Kim has posted comments on this change. Change subject: Fixed issue 920: consecutive index-nested-loop joins fail. Index-nested-loop join now tries to use an index on the inner relation first. ......................................................................
Patch Set 3: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/346/3/asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: Line 549: if (funcVarIndex == -1) { > Can you reuse the code with the first case above? Done https://asterix-gerrit.ics.uci.edu/#/c/346/3/asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java File asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java: Line 157: // Check whether we can remove the indexes from the outer relations > "remove"-->"choose"? The purpose is removing any candidate indexes from the outer relation since we want to use indexes from the inner relation first. I put more comments. https://asterix-gerrit.ics.uci.edu/#/c/346/3/asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java File asterix-algebra/src/main/java/edu/uci/ics/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java: Line 72: public List<Mutable<ILogicalOperator>> additionalDataSourceRefs = null; > Can you name the variables more explicitly? Done Line 126: // There can be multiple unnest-map or datasource-scan operators > This code only works for two unnest-maps? It can works for multiple unnest-maps. Line 157: if (additionalDataSourceRefs == null) { > Can you move if(additionalDataSourceRefs==null) into initalizeAdditionalDat Done -- To view, visit https://asterix-gerrit.ics.uci.edu/346 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63e445950aaf5f1e756757c9f1d6167a6fe6b12b Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Pouria Pirzadeh <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
