Heri Ramampiaro has posted comments on this change. Change subject: polishing the feeds docs Change-Id: I46420c770ab194190bf122965f5e7525893ed128 ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Hi, I just added two comments related to the name of the process tweet function and "discarding" "unwanted" results... (The last one is not necessary for this to pass the review:-)) Thanks, -heri https://asterix-gerrit.ics.uci.edu/#/c/359/2/asterix-doc/src/site/markdown/feeds/tutorial.md File asterix-doc/src/site/markdown/feeds/tutorial.md: Line 184: apply function testlib#processRawTweet; I believe this is called "testlib#addHashTags" now. I have suggested changing it back to its original name (that is the same as used in this document), which makes more sense to me... Line 377: Minor: Maybe we could add a note stating that that sometime it might be useful to allow a function to return "null" or a user just do not want ingest a feed with certain result values. With the last version of the feeds (with my changes), this is supported... -- To view, visit https://asterix-gerrit.ics.uci.edu/359 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46420c770ab194190bf122965f5e7525893ed128 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Chen Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Heri Ramampiaro <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
