Steven Jacobs has posted comments on this change. Change subject: Introduced Local Filesystem Feed Adapter ......................................................................
Patch Set 3: (2 comments) A couple of comments on my first pass. As far as I can tell, this doesn't take action fro file deletes or line changes, right? https://asterix-gerrit.ics.uci.edu/#/c/376/3/asterix-app/data/local-dir/data/hello-world File asterix-app/data/local-dir/data/hello-world: Line 2: I'm assuming the misspelling is for a purpose? https://asterix-gerrit.ics.uci.edu/#/c/376/3/asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LocalFileSystemFeedAdapter.java File asterix-external-data/src/main/java/org/apache/asterix/external/dataset/adapter/LocalFileSystemFeedAdapter.java: Line 56: // This needs to be fixed This comment isn't clear to me. -- To view, visit https://asterix-gerrit.ics.uci.edu/376 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707756e3b4c9ffca4b55ec9817a08e5c16333010 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-HasComments: Yes
