Till Westmann has posted comments on this change. Change subject: Fix source packaging, address misc. release issues ......................................................................
Patch Set 1: Code-Review-1 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/381/1/LICENSE File LICENSE: Line 10: --- I'm sorry I was unclear on this int he e-mail. But I think that the license text needs to be in the source archive - either in the LICENSE file or in another file in the archive (http://www.apache.org/dev/licensing-howto.html#permissive-deps). As an example I would look at https://github.com/apache/subversion/blob/trunk/LICENSE which puts the licenses for subcomponents at the end of the LICENSE file with pointers to the location of the files in the source tree. https://asterix-gerrit.ics.uci.edu/#/c/381/1/pom.xml File pom.xml: Line 156: <exclude>**/actual/customer_result/part-*</exclude> Aren't those files just around when the tests have been run? Are they really part of the archive? -- To view, visit https://asterix-gerrit.ics.uci.edu/381 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98b18f24a20dcd8dc75e828e47fb0ab88179a4ef Gerrit-PatchSet: 1 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
