What would be the best way to fit examples into the build process? I already have some (slightly unorganized) Jasmine tests locally that could be included, but I'm not sure how to update the existing test pipeline. Sorry in advance if this is a well-documented topic :(!
On Tue, Nov 3, 2015 at 3:41 PM, Mike Carey <[email protected]> wrote: > Agreed on examples needing to be in the build flow! > > > On 11/3/15 1:54 PM, Chris Hillery wrote: > >> Yes, the output format changed - more than a year ago now. I did recently >> notice that the documentation was out of date, and I will fix that. As for >> the examples, I was unaware of those, but clearly those need to be updated >> as well. We should probably ensure that all of our examples can be run as >> part of a build, to prevent them breaking. >> >> Ceej >> aka Chris Hillery >> >> On Tue, Nov 3, 2015 at 1:40 PM, Jianfeng Jia <[email protected]> >> wrote: >> >> Dear Devs, >>> >>> I just noticed that the HTTP response format from current master is >>> different from the master's documentation page( >>> >>> https://asterix-jenkins.ics.uci.edu/job/asterix-test-full/site/asterix-doc/api.html#QueryApi >>> < >>> >>> https://asterix-jenkins.ics.uci.edu/job/asterix-test-full/site/asterix-doc/api.html#QueryApi >>> >). >>> The documentation says it was wrapped by a json dictionary as following: >>> >>> { >>> "results": [ >>> [ >>> "{ "id": 123, "name": "John Doe" }" >>> ] >>> ] >>> } >>> But what I got from >>> >>> http://localhost:19002/query?query=use%20dataverse%20company;for%20$l%20in%20dataset( >>> ‘Employee’)%20return%20$l; >>> is just an array (as we produced in the Asterix web interface) >>> [ >>> { "id": 123, "name": "John Doe" } >>> ] >>> It breaks the asterix-examples javascript demos. So I want to ask that >>> the >>> HTTP response changes was intended or not. If so we should update the >>> documentation and the corresponding javascript demos. Otherwise we should >>> bring back the old response format. >>> >>> >>> >>> >>> Best, >>> >>> Jianfeng Jia >>> PhD Candidate of Computer Science >>> University of California, Irvine >>> >>> >>> >
