I’m completely open on the 2-vs-4 question - the wiki can be changed
:)
Also, the ASF’s mode of governance is sometimes called a "do-ocracy"
[1], so if you do it, it might just stick :)
Cheers,
Till
[1] http://www.apache.org/foundation/how-it-works.html
On 16 Mar 2016, at 3:12, Michael Blow wrote:
Thanks Preston for pointing out the existing albeit largely ignored
convention, which I neglected to mention; Till had pointed me to the
same.
Id like to amend the existing convention to two-spaces, then work to
bring
existing files into compliance.
Thanks,
-MDB
On Wed, Mar 16, 2016 at 2:00 AM Preston Carman <prest...@apache.org>
wrote:
On our website [1] we have stated a convention of using 4 spaces.
Although
the code base is wildly inconsistent. I think actually using a
convention
will support simpler code reviews, since they are line based
comparisons.
[1] https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting
On Tue, Mar 15, 2016 at 9:07 PM, Till Westmann <ti...@apache.org>
wrote:
Hi Jochen,
On 15 Mar 2016, at 12:20, Jochen Wiedmann wrote:
On Tue, Mar 15, 2016 at 8:14 PM, Michael Blow
<mblow.apa...@gmail.com>
wrote:
Currently XML files in asterixdb (including hyracks) have a wide
variety
of
indentation schemes being used, often times within a single file,
which
makes maintenance quite painful.
Please let me know your thoughts / opinions.
My opinion (out of experience): *Never* bother with syntax, when
XML
is the topic. XML is about semantics, not syntax. Trying ti achieve
a
particular syntax will never work.
If we’d all use tools that represent the XML structure and if git
would
provide a tree diff for XML, I think that I might agree with you.
However, my current reality is that I use a text editor to edit XML
files and git’s diff is line oriented.
So I think that consistent indentation of XML is helpful. And since
XML
processors don’t care about non-significant whitespace it also
doesn’t
hurt them.
I’m in favor of a common indentation scheme.
Cheers,
Till
