----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60285/#review178673 -----------------------------------------------------------
distro/src/conf/policy-store.txt Line 9 (original), 9 (patched) <https://reviews.apache.org/r/60285/#comment252818> Iwonder what tagsync means for relationships - I assume we are supporting tags of relational attributes - is this what this enables? - are we supporting classifications on relationships? intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java Line 78 (original), 90 (patched) <https://reviews.apache.org/r/60285/#comment252821> I am wondering why we need to validate the relationshipDef in relationship instance logic intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java Lines 214 (patched) <https://reviews.apache.org/r/60285/#comment252822> bad character intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java Lines 215 (patched) <https://reviews.apache.org/r/60285/#comment252823> I thought we were not supporintg LIST - David Radley On June 21, 2017, 7:14 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60285/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 7:14 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, > Nixon Rodrigues, and Suma Shivaprasad. > > > Bugs: ATLAS-1892 > https://issues.apache.org/jira/browse/ATLAS-1892 > > > Repository: atlas > > > Description > ------- > > When a new relationshipDef is created, relation attributes needs to be > populated in AtlasEntityType during resolveReference stage. > This JIRA also adds UT, IT and addresses review comments in > https://reviews.apache.org/r/59769/ > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java > 925b6b13 > > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java > bb3157a3 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java > acf73882 > distro/src/conf/policy-store.txt 47583c1e > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e8971a80 > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java > 34e932ed > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a29f7fb6 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 38b68bbd > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java > 7a4e9fd5 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 8fe48885 > webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java > 144080ad > > > Diff: https://reviews.apache.org/r/60285/diff/2/ > > > Testing > ------- > > UT added and tested. > IT in progress. > > > Thanks, > > Sarath Subramanian > >
