Review Request 60601: ATLAS-1012 Coverity issues raised in AtlasRelationshipDefStoreV1

[David Radley]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60601/
-----------------------------------------------------------

Review request for atlas and Madhan Neethiraj.


Repository: atlas


Description
-------

** CID 164823:  Null pointer dereferences  (NULL_RETURNS)
    
/repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java:
 88 in 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1.preCreate(org.apache.atlas.model.typedef.AtlasRelationshipDef)()
    
    
    
________________________________________________________________________________________________________
    *** CID 164823:  Null pointer dereferences  (NULL_RETURNS)
    
/repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java:
 88 in 
org.apache.atlas.repository.store.graph.v1.AtlasRelationshipDefStoreV1.preCreate(org.apache.atlas.model.typedef.AtlasRelationshipDef)()
    82             final String type1 = endDef1.getType();
    83             final AtlasRelationshipEndDef endDef2 = 
relationshipDef.getEndDef2();
    84             final String type2 = endDef2.getType();
    85             final String name1 = endDef1.getName();
    86             final String name2 = endDef2.getName();
    87     
    >>>     CID 164823:  Null pointer dereferences  (NULL_RETURNS)
    >>>     Assigning: "end1TypeVertex" = null return value from 
"findTypeVertexByName".
    88             AtlasVertex end1TypeVertex = 
typeDefStore.findTypeVertexByName(type1);
    89     
    90             AtlasVertex end2TypeVertex = 
typeDefStore.findTypeVertexByName(type2);
    91             // create an edge between the relationshipDef and each of 
the entityDef vertices.
    92             AtlasEdge edge1 = 
typeDefStore.getOrCreateEdge(relationshipDefVertex, end1TypeVertex, 
AtlasGraphUtilsV1.RELATIONSHIPTYPE_EDGE_LABEL);


Diffs
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 
49ead6e39e623a617cd3c90405bb41a348f79624 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
 bd7416e6f699773e7477c89b9fcdfb2fccacdcfc 


Diff: https://reviews.apache.org/r/60601/diff/1/


Testing
-------

Ran units tests 
Created a relationshipDef.


Thanks,

David Radley